Skip to content

feat: terminal split screen operation supports single deletion#3043

Merged
bytemain merged 11 commits intomainfrom
feat/termnal_add_remove
Mar 23, 2024
Merged

feat: terminal split screen operation supports single deletion#3043
bytemain merged 11 commits intomainfrom
feat/termnal_add_remove

Conversation

@wangxiaojuan
Copy link
Copy Markdown
Contributor

@wangxiaojuan wangxiaojuan commented Sep 5, 2023

Types

  • 🎉 New Features

feat: #3042

Background or solution

image

Changelog

feat: 终端分屏时支持单个面板删除

🤖 Generated by Copilot at 0e22038

The pull request enhances the terminal tab functionality by adding a close button and improving the style. It also refactors some code to use core browser utilities and hooks in resize.view.tsx and resize.module.less.

@opensumi opensumi Bot added the 🎨 feature feature required label Sep 5, 2023
@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Sep 5, 2023

ChatGPT Code Review:

  1. 代码存在错误,文件路径 https://github.com/opensumi/core/assets/1762334/6d3a4ea3-035b-4015-89e0-690499c83fb3 在代码中被引用,但是应该是相对路径,而不是 URL。
    建议修改为 ../assets/1762334/6d3a4ea3-035b-4015-89e0-690499c83fb3

  2. 代码存在拼写错误,resizeItem 应该是 resize-item
    建议修改为 resize-item

  3. 代码存在拼写错误,kticon-close 应该是 kt-icon-close
    建议修改为 kt-icon-close

代码的功能是在终端分屏组件中添加了一个可以单个面板删除的功能。具体实现为在每个面板后添加了一个关闭图标,点击该图标可以删除对应的面板。

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 823 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@bytemain
Copy link
Copy Markdown
Member

bytemain commented Sep 6, 2023

我感觉直接展示太多余了,可不可以做成用户鼠标移动到当前 terminal 上的时候,再显示这个 X

Comment thread packages/terminal-next/src/browser/component/resize.view.tsx
@wangxiaojuan wangxiaojuan requested a review from erha19 September 26, 2023 09:59
Comment thread packages/terminal-next/src/browser/component/resize.module.less Outdated
@wangxiaojuan wangxiaojuan requested a review from erha19 October 16, 2023 01:49
erha19
erha19 previously requested changes Oct 16, 2023
Comment thread packages/terminal-next/src/browser/component/resize.view.tsx
Comment thread packages/terminal-next/src/browser/component/resize.module.less
@wangxiaojuan wangxiaojuan requested a review from erha19 November 1, 2023 02:40
@bytemain bytemain merged commit 2d7702a into main Mar 23, 2024
@bytemain bytemain deleted the feat/termnal_add_remove branch March 23, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants