Skip to content

fix: terminal search box supports toggle switching#3041

Merged
bytemain merged 1 commit intomainfrom
fix/search_toggle
Sep 6, 2023
Merged

fix: terminal search box supports toggle switching#3041
bytemain merged 1 commit intomainfrom
fix/search_toggle

Conversation

@wangxiaojuan
Copy link
Copy Markdown
Contributor

@wangxiaojuan wangxiaojuan commented Sep 5, 2023

Types

  • 🐛 Bug Fixes

fix: #3040

Background or solution

image

Changelog

fix: 终端点击搜索时支持toggle模式

🤖 Generated by Copilot at 58045b8

Fixed a bug that caused multiple terminal search widgets to appear when using the find command. Added code to executeTerminalFind in terminal.command.ts to close the existing widget before opening a new one.

@wangxiaojuan wangxiaojuan requested a review from Ricbet September 5, 2023 11:36
@opensumi opensumi Bot added the 🐞 bug Something isn't working label Sep 5, 2023
@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Sep 5, 2023

ChatGPT Code Review:

代码审查和修改建议:

  1. 第一个问题是代码审查,代码中没有明显的错误或错误拼写。
  2. 代码的功能是在终端点击搜索时,支持 toggle 模式。也就是说,当搜索框已经打开时再点击搜索,则关闭搜索框;当搜索框未打开时点击搜索,则打开搜索框。

根据上述描述,我对代码没有任何修改建议。

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
...-next/src/browser/contribution/terminal.command.ts 0.00%

📢 Thoughts on this report? Let us know!.

@bytemain bytemain merged commit e3f6649 into main Sep 6, 2023
@bytemain bytemain deleted the fix/search_toggle branch September 6, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 终端点击搜索Icon可以展示或者隐藏搜索框

2 participants