Skip to content

fix: search box placeholder color#3039

Merged
bytemain merged 2 commits intomainfrom
fix/search_placeholder_color
Sep 19, 2023
Merged

fix: search box placeholder color#3039
bytemain merged 2 commits intomainfrom
fix/search_placeholder_color

Conversation

@wangxiaojuan
Copy link
Copy Markdown
Contributor

Types

  • 🐛 Bug Fixes

fix: #3038

Background or solution

image
image

Changelog

fix:终端搜索框placeholder颜色不正确

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Sep 5, 2023
@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Sep 5, 2023

ChatGPT Code Review:

检查结果如下:

  1. 在代码中存在一些错误和问题:

    • terminal.module.less 文件中,已经被注释掉的 input 部分代码被重复删除了,这可能导致代码功能异常。建议将 input 部分代码恢复到原有的样式。
    • terminal.view.tsx 文件中,input 元素被包裹在了一个 div 元素内,这可能导致样式渲染问题,建议将 div 元素去除。
  2. 该代码的功能是修复终端搜索框中 placeholder 颜色不正确的问题。修复的方法是在样式文件 terminal.module.less 中删除了被注释的 backgroundborderoutline 样式,并修改 input 样式以及添加了一个新的 div 元素用于包裹 input 元素。

注意:以上建议仅供参考,具体的修改需根据代码的使用环境和需求进行评估。

@wangxiaojuan wangxiaojuan requested a review from Ricbet September 5, 2023 11:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@bytemain
Copy link
Copy Markdown
Member

/backport v2.26

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Sep 11, 2023

Backporting to v2.26 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

Comment thread packages/terminal-next/src/browser/component/terminal.module.less Outdated
@opensumi opensumi Bot mentioned this pull request Sep 11, 2023
1 task
@wangxiaojuan wangxiaojuan requested a review from erha19 September 13, 2023 07:15
@bytemain bytemain merged commit e1871d3 into main Sep 19, 2023
@bytemain bytemain deleted the fix/search_placeholder_color branch September 19, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 终端搜索框placeholder颜色高亮

3 participants