fix: custom components are not destroyed after being closed#3036
Merged
MMhunter merged 3 commits intoSep 8, 2023
Conversation
Member
|
@MMhunter 看一下这个 PR,我看着没啥问题 |
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
MMhunter
requested changes
Sep 5, 2023
xkaede
commented
Sep 5, 2023
Contributor
Author
|
@MMhunter 已调整 |
MMhunter
approved these changes
Sep 8, 2023
Contributor
|
LGTM |
Member
|
/backport to v2.26 |
Contributor
|
Backporting to |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
详情参见:#3034 (comment)
添加了component-editor-view.tsx文件用于复现。确认没有问题后。我来删除这个文件。
复现步骤:
1、新建文件“test.cmp”、"test.txt"
2、打开文件“test.cmp”,关闭“test.cmp”。控制台输出1(未修复前不会输出。)
3、打开文件“test.cmp”、"test.txt",保持“test.cmp”为当前Tab,关闭“test.cmp”。控制台输出1(未修复前会正确输出。)
4、打开文件“test.cmp”、"test.txt",保持“test.txt”为当前Tab,关闭“test.cmp”。控制台输出1(未修复前不会输出。)
Background or solution
🤖 Generated by Copilot at d66d41e
.cmpfiles (link, link, link)Changelog
🤖 Generated by Copilot at d66d41e
This pull request enhances the editor service to support custom editor components and adds an example of such a component for
.cmpfiles. It also fixes some issues with the editor component lifecycle when switching editor groups or tabs.