Skip to content

feat: support vscode.l10n api#3002

Merged
erha19 merged 7 commits intomainfrom
feat/support-l10n-api
Aug 28, 2023
Merged

feat: support vscode.l10n api#3002
erha19 merged 7 commits intomainfrom
feat/support-l10n-api

Conversation

@erha19
Copy link
Copy Markdown
Member

@erha19 erha19 commented Aug 18, 2023

Types

  • 🎉 New Features

Background or solution

🤖 Generated by Copilot at e4fbb0b

相关:#2341

Changelog

🤖 Generated by Copilot at e4fbb0b

This pull request updates the version of the core package and its dependencies to 2.26.6, which includes a bug fix for the keybinding registry and a code simplification for the select component. The bug fix resolves a keybinding conflict issue caused by a persistent modifier key sequence. The code simplification removes unnecessary CSS classes and improves readability and maintainability.

@opensumi opensumi Bot added the 🎨 feature feature required label Aug 18, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2023

Codecov Report

Patch coverage: 47.24% and project coverage change: -0.02% ⚠️

Comparison is base (12b6653) 57.62% compared to head (b89ae86) 57.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
- Coverage   57.62%   57.60%   -0.02%     
==========================================
  Files        1337     1339       +2     
  Lines       84174    84290     +116     
  Branches    17493    17518      +25     
==========================================
+ Hits        48503    48558      +55     
- Misses      32417    32471      +54     
- Partials     3254     3261       +7     
Flag Coverage Δ
jsdom 52.62% <44.09%> (-0.01%) ⬇️
node 16.78% <5.51%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/extension/src/common/extension.ts 84.02% <ø> (ø)
packages/extension/src/common/vscode/extension.ts 52.00% <ø> (ø)
packages/extension/src/hosted/ext.process-base.ts 0.00% <0.00%> (ø)
packages/extension/src/hosted/worker.host.ts 82.31% <ø> (ø)
...ion/src/hosted/api/vscode/ext.host.localization.ts 27.94% <27.94%> (ø)
...ges/extension/src/node/extension.service.client.ts 65.06% <57.14%> (-1.61%) ⬇️
...ion/src/browser/vscode/api/main.thread.api.impl.ts 42.54% <60.00%> (+0.39%) ⬆️
...src/browser/vscode/api/main.thread.localization.ts 60.00% <60.00%> (ø)
packages/utils/src/strings.ts 37.28% <66.66%> (+0.19%) ⬆️
packages/extension/src/common/vscode/index.ts 100.00% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 changed the title WIP: feat: support vscode.l10n api feat: support vscode.l10n api Aug 21, 2023
@erha19
Copy link
Copy Markdown
Member Author

erha19 commented Aug 21, 2023

测试插件: https://github.com/microsoft/vscode-extension-samples/tree/main/l10n-sample

需要修改插件 package.json 内的 activationEvents 为 *:

"activationEvents": [
  "*"
]
截屏2023-08-21 21 50 19

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Aug 22, 2023
@erha19 erha19 force-pushed the feat/support-l10n-api branch from c77ec3f to 810dd50 Compare August 28, 2023 02:24
Comment thread packages/types/vscode.d.ts Outdated
bytemain
bytemain previously approved these changes Aug 28, 2023
@erha19 erha19 merged commit c382e39 into main Aug 28, 2023
@erha19 erha19 deleted the feat/support-l10n-api branch August 28, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working 🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants