Merged
Conversation
Contributor
|
ChatGPT Code Review: 根据提交的代码和描述,我对代码进行了审查和修改建议,并描述了代码的功能。 修改建议:
代码功能:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2.26 #2956 +/- ##
=======================================
Coverage 57.62% 57.63%
=======================================
Files 1337 1337
Lines 84150 84154 +4
Branches 17489 17490 +1
=======================================
+ Hits 48491 48501 +10
+ Misses 32408 32403 -5
+ Partials 3251 3250 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
84eeb3f to
df07c51
Compare
Member
Author
|
/next |
Contributor
|
🎉 PR Next version 2.26.3-next-1690853207.0 publish successful! You can install this version via |
erha19
approved these changes
Aug 1, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
editorCollectionService 中将 DiffEditor 中左右两侧的 CodeEditor 包装为 DiffEditorPart,并在一些情况下更新它们的 options,这会将 CodeEditor 的 options 错误的更新到 DiffEditor 中,导致即使 monaco 内部已经在创建 DiffEditor 时关闭了 minimap,也会因为这段逻辑在一些情况下自动开启 minimap。
解决方式是根据 EditorType 区分不同的设置项,对于这种可能混淆的情况,新增了 diffEditor 的自定义配置项,在应用时会自动转换为 editor 配置
🤖 Generated by Copilot at 3f87b17
diffOptionswitheditorOptionswhen editor type is greater thanEditorType.CODEineditor-collection.service.ts(link)diffEditor.minimappreference inconverter.tsandschema.ts(link, link)Changelog
🤖 Generated by Copilot at 3f87b17
This pull request adds support for the diff editor feature that allows comparing two files side by side. It modifies the
editor-collection.service.ts,converter.ts, andschema.tsfiles to handle thediffOptions,diffEditor.minimappreference, and the minimap option of the Monaco editor.