Skip to content

chore: remove unused import vars#2856

Merged
pipiiiiii merged 1 commit into
mainfrom
chore/remove-unused-import
Jun 29, 2023
Merged

chore: remove unused import vars#2856
pipiiiiii merged 1 commit into
mainfrom
chore/remove-unused-import

Conversation

@pipiiiiii
Copy link
Copy Markdown
Contributor

@pipiiiiii pipiiiiii commented Jun 29, 2023

Types

  • 💄 Code Style Changes
  • 🧹 Chores

Background or solution

🤖 Generated by Copilot at 81427b2

Changelog

这个 PR 主要是处理代码中一些未使用的 import 依赖,同时增加插件 unused-imports 使得 lint:fix 可以自动移除未使用的依赖项

  • devDependencies 增加 eslint-plugin-unused-imports
  • .eslintrc.js 增加
    • plugin: unused-imports
    • rules: 'unused-imports/no-unused-imports': 'warn'
  • remove unused import vars

@pipiiiiii pipiiiiii requested a review from Ricbet June 29, 2023 09:26
@opensumi opensumi Bot added the 🐞 bug Something isn't working label Jun 29, 2023
@pipiiiiii pipiiiiii requested a review from erha19 June 29, 2023 09:26
@pipiiiiii pipiiiiii added ⚙️ refactor Refactor code and removed 🐞 bug Something isn't working labels Jun 29, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 29, 2023

Codecov Report

Patch coverage: 81.81% and no project coverage change.

Comparison is base (04c6527) 57.62% compared to head (81427b2) 57.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2856   +/-   ##
=======================================
  Coverage   57.62%   57.62%           
=======================================
  Files        1336     1336           
  Lines       83975    83975           
  Branches    17462    17462           
=======================================
  Hits        48390    48390           
  Misses      32342    32342           
  Partials     3243     3243           
Flag Coverage Δ
jsdom 52.65% <81.81%> (ø)
node 16.78% <9.09%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/comments/src/browser/comments.service.ts 51.29% <ø> (ø)
packages/core-node/src/connection.ts 66.15% <ø> (ø)
...r/view/console/debug-console-tree.model.service.ts 68.30% <ø> (ø)
packages/editor/src/browser/breadcrumb/default.ts 51.85% <ø> (ø)
...ages/editor/src/browser/fs-resource/fs-resource.ts 69.79% <ø> (ø)
...kages/editor/src/browser/menu/breadcrumbs.menus.ts 50.00% <ø> (ø)
...ackages/extension/src/common/vscode/editor-tabs.ts 100.00% <ø> (ø)
packages/extension/src/common/vscode/index.ts 100.00% <ø> (ø)
packages/extension/src/common/vscode/scm.ts 57.14% <ø> (ø)
.../src/hosted/api/vscode/ext.host.window.api.impl.ts 12.40% <ø> (ø)
... and 33 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pipiiiiii pipiiiiii merged commit 2bf2b3b into main Jun 29, 2023
@pipiiiiii pipiiiiii deleted the chore/remove-unused-import branch June 29, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ refactor Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants