Skip to content

feat: auto expand the comment widget when click comment tree item#2777

Merged
erha19 merged 1 commit intomainfrom
feat/auto-expand-collapsed-comment
Jun 7, 2023
Merged

feat: auto expand the comment widget when click comment tree item#2777
erha19 merged 1 commit intomainfrom
feat/auto-expand-collapsed-comment

Conversation

@Aaaaash
Copy link
Copy Markdown
Member

@Aaaaash Aaaaash commented Jun 6, 2023

Types

  • 🎉 New Features

Background or solution

🤖 Generated by Copilot at 1149c82

  • Fix a bug where the comment thread would not be visible when opening a file from the comment tree (link)

Changelog

🤖 Generated by Copilot at 1149c82

Fix comment thread visibility when opening files from comment tree. Use editorService.open promise to show comment thread of opened node in tree-model.service.ts.

@opensumi opensumi Bot added the 🎨 feature feature required label Jun 6, 2023
Comment thread packages/comments/src/browser/tree/tree-model.service.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d308858) 57.69% compared to head (1149c82) 57.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2777      +/-   ##
==========================================
- Coverage   57.69%   57.68%   -0.01%     
==========================================
  Files        1333     1333              
  Lines       83844    83847       +3     
  Branches    17431    17432       +1     
==========================================
  Hits        48371    48371              
- Misses      32243    32245       +2     
- Partials     3230     3231       +1     
Flag Coverage Δ
jsdom 52.70% <0.00%> (-0.01%) ⬇️
node 16.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/comments/src/browser/tree/tree-model.service.ts 11.76% <0.00%> (-0.36%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 3a2edd8 into main Jun 7, 2023
@erha19 erha19 deleted the feat/auto-expand-collapsed-comment branch June 7, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants