feat: optimize file tree node decoration, support codicon#2768
Merged
Conversation
0b4f179 to
68a0876
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2768 +/- ##
==========================================
+ Coverage 57.71% 57.73% +0.01%
==========================================
Files 1327 1327
Lines 83587 83587
Branches 17381 17381
==========================================
+ Hits 48246 48255 +9
+ Misses 32119 32111 -8
+ Partials 3222 3221 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
/next |
Contributor
|
🎉 PR Next version 2.24.6-next-1685606139.0 publish successful! You can install this version via |
erha19
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
fileTreeNode 的 decoration 支持 codicon
🤖 Generated by Copilot at 0b4f179
transformLabelWithCodiconfunction to render codicons in the file tree node status badges (link, link)iconServiceprop to theFileTreeNodecomponent to use itsfromStringmethod to render codicons (link, link, link, link, link)Changelog
🤖 Generated by Copilot at 0b4f179
This pull request adds codicon support to the file tree nodes in the
file-tree-nextpackage. It uses theIIconServiceand a utility function from the@opensumi/ide-themepackage to render the status badges with codicons. It also improves the CSS styles of the file tree node element.