fix: check if element of popover exists when delayed hidden#2764
Merged
Conversation
Contributor
|
ChatGPT Code Review:
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2764 +/- ##
==========================================
- Coverage 57.72% 57.72% -0.01%
==========================================
Files 1327 1327
Lines 83582 83583 +1
Branches 17379 17379
==========================================
Hits 48246 48246
- Misses 32115 32116 +1
Partials 3221 3221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ricbet
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖 Generated by Copilot at 0cb6734
contentEl.currentto avoid errors when the popover is unmounted (link)Changelog
🤖 Generated by Copilot at 0cb6734
Fix a potential error in
Popovercomponent when unmounting. Add a null check forcontentEl.currentinhideContentfunction.