Skip to content

fix: monaco Action Bar style#2720

Merged
Ricbet merged 1 commit intomainfrom
fix/peekview
May 19, 2023
Merged

fix: monaco Action Bar style#2720
Ricbet merged 1 commit intomainfrom
fix/peekview

Conversation

@wangxiaojuan
Copy link
Copy Markdown
Contributor

Types

  • 🐛 Bug Fixes

Background or solution

fixed: #2700
image

Changelog

fix: 修复monaco action bar 图标显示不居中的问题

@opensumi opensumi Bot added 🐞 bug Something isn't working 💄 style change labels May 17, 2023
@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented May 17, 2023

ChatGPT Code Review:

  1. 这段代码的主要修改是修复 monaco action bar 中图标不居中的问题。具体的修改是在 .action-item 中增加了 display: flex;,并将 margin-left 改为 margin: 0 6px;,使图标在 action bar 中居中显示。
  2. 功能描述:修改样式以修复 monaco action bar 的图标不居中问题。

@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b085e3f) 57.72% compared to head (d97588e) 57.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2720   +/-   ##
=======================================
  Coverage   57.72%   57.73%           
=======================================
  Files        1327     1327           
  Lines       83563    83563           
  Branches    17381    17381           
=======================================
+ Hits        48238    48245    +7     
+ Misses      32104    32098    -6     
+ Partials     3221     3220    -1     
Flag Coverage Δ
jsdom 52.73% <ø> (+<0.01%) ⬆️
node 16.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread packages/testing/src/browser/outputPeek/test-peek-widget.less
@wangxiaojuan wangxiaojuan requested a review from erha19 May 18, 2023 02:06
@Ricbet Ricbet merged commit eeaa213 into main May 19, 2023
@Ricbet Ricbet deleted the fix/peekview branch May 19, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working 💄 style change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Monaco Action Bar 图标样式存在问题

3 participants