Skip to content

feat: support flashing prompt for focus breakpoints in the editor#2652

Merged
Ricbet merged 7 commits intomainfrom
feat/support-debug-breakpoint-focus-ssparkle
May 4, 2023
Merged

feat: support flashing prompt for focus breakpoints in the editor#2652
Ricbet merged 7 commits intomainfrom
feat/support-debug-breakpoint-focus-ssparkle

Conversation

@Ricbet
Copy link
Copy Markdown
Member

@Ricbet Ricbet commented Apr 26, 2023

Types

  • 🎉 New Features

Background or solution

🤖 Generated by Copilot at 2ccbacd

  • Add less variables for debug colors and use them for editor decorations (link, link, link)
  • Inject and use DebugBreakpointsService to provide events and methods for breakpoints and stack frames (link, link, link, link, link)
  • Implement focus breakpoints stack frame line feature to highlight the stack frame that corresponds to the breakpoint that was hit (link, link, link, link, link, link, link)
  • Use proper types and syntax for opening resources in the editor from the breakpoints view (link, link)

Kapture 2023-04-26 at 15 15 14

Changelog

🤖 Generated by Copilot at 2ccbacd

This pull request enhances the debug module with new features and styles for breakpoints and stack frames. It introduces less variables for debug colors, animates the focus breakpoints stack frame line in the editor, and improves the type safety and functionality of the breakpoints view. It also refactors some code and adds new events and methods to the DebugBreakpointsService class. The changes affect the files debug-style.less, debug-model.ts, debug-breakpoints.service.ts, debug-breakpoints.view.tsx, and debug-styles.ts.

@Ricbet Ricbet self-assigned this Apr 26, 2023
@opensumi opensumi Bot added 🎨 feature feature required ⚙️ refactor Refactor code 💄 style change labels Apr 26, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2023

Codecov Report

Patch coverage: 38.09% and project coverage change: -0.02 ⚠️

Comparison is base (f0d708f) 57.65% compared to head (360d737) 57.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
- Coverage   57.65%   57.64%   -0.02%     
==========================================
  Files        1327     1327              
  Lines       83631    83676      +45     
  Branches    17418    17421       +3     
==========================================
+ Hits        48219    48235      +16     
- Misses      32174    32201      +27     
- Partials     3238     3240       +2     
Flag Coverage Δ
jsdom 52.65% <38.09%> (-0.02%) ⬇️
node 16.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/core-preferences.ts 92.85% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...erences/src/browser/preference-settings.service.ts 73.09% <ø> (+0.89%) ⬆️
packages/debug/src/browser/editor/debug-model.ts 51.00% <31.25%> (-1.47%) ⬇️
...wser/view/breakpoints/debug-breakpoints.service.ts 65.64% <50.00%> (-0.50%) ⬇️
packages/debug/src/browser/editor/debug-styles.ts 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

bytemain
bytemain previously approved these changes Apr 28, 2023
Copy link
Copy Markdown
Member

@bytemain bytemain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/debug/src/browser/debug-style.less Outdated
Comment thread packages/debug/src/browser/editor/debug-model.ts Outdated
Comment thread packages/debug/src/browser/editor/debug-model.ts Outdated
@Ricbet Ricbet requested a review from erha19 April 28, 2023 08:19
@Ricbet
Copy link
Copy Markdown
Member Author

Ricbet commented May 4, 2023

  • 新增 preference 配置项,控制是否开启该功能,默认开启

Comment thread packages/debug/src/browser/editor/debug-model.ts Outdated
@Ricbet Ricbet merged commit 5bc1426 into main May 4, 2023
@Ricbet Ricbet deleted the feat/support-debug-breakpoint-focus-ssparkle branch May 4, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants