Skip to content

feat(editor): editor save code action notify configuration#2599

Merged
erha19 merged 1 commit intoopensumi:mainfrom
shilin8805:feat/editor-code-action-notifaction
Apr 18, 2023
Merged

feat(editor): editor save code action notify configuration#2599
erha19 merged 1 commit intoopensumi:mainfrom
shilin8805:feat/editor-code-action-notifaction

Conversation

@shilin8805
Copy link
Copy Markdown
Contributor

@shilin8805 shilin8805 commented Apr 18, 2023

Types

  • 🎉 New Features

编辑器模块执行saveCodeActions时默认会弹出Notification提示,新增配置可选是否弹窗提示。

Background or solution

🤖 Generated by Copilot at b9c7a2c

  • Add new preference options to control code actions on save and the notification message
  • Define the schema and default values for editor.codeActionsOnSaveNotification and editor.unicodeHighlight.ambiguousCharacters in monacoEditorSchema (link,link)
  • Add the preference labels and descriptions to the English and Chinese localization bundles (link,link,link,link)
  • Include the new options in the preference UI under the "Code Actions" group (link)
  • Extract the code from the save method of SaveParticipant into runActions (link)
  • Pass the progress parameter to runActions and check for its nullity before reporting progress (link)

Changelog

🤖 Generated by Copilot at b9c7a2c

This pull request enhances the code actions on save feature in the editor by adding new preference options, a notification toggle, and localization support. It updates the files saveParticipants.ts, schema.ts, en-US.lang.ts, zh-CN.lang.ts, and preference-settings.service.ts to implement these changes. It also upgrades the monaco editor dependency to the latest version.

@github-actions github-actions Bot added the 🎨 feature feature required label Apr 18, 2023
@shilin8805
Copy link
Copy Markdown
Contributor Author

@erha19 hello~这个PR之前合并到main分支了,我想在2.23版本用,能帮忙publish一个补丁版本吗?我自己用。

@erha19
Copy link
Copy Markdown
Member

erha19 commented Apr 18, 2023

@erha19 hello~这个PR之前合并到main分支了,我想在2.23版本用,能帮忙publish一个补丁版本吗?我自己用。

@shilin8805 https://github.com/opensumi/core/actions/runs/4730354871 可以用这里一会发布的版本,基于 main 的,如果有问题我在单独给你 patch 一个补丁版本

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2023

Codecov Report

Patch coverage: 55.75% and project coverage change: +0.01 🎉

Comparison is base (0c5a446) 57.76% compared to head (b9c7a2c) 57.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.23    #2599      +/-   ##
==========================================
+ Coverage   57.76%   57.77%   +0.01%     
==========================================
  Files        1319     1324       +5     
  Lines       83239    83525     +286     
  Branches    17334    17394      +60     
==========================================
+ Hits        48079    48257     +178     
- Misses      31952    32046      +94     
- Partials     3208     3222      +14     
Flag Coverage Δ
jsdom 52.78% <52.21%> (+<0.01%) ⬆️
node 16.77% <16.51%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...collaboration/src/browser/collaboration.service.ts 70.22% <0.00%> (+1.12%) ⬆️
...ckages/components/src/icon/iconfont/iconManager.ts 90.32% <ø> (ø)
packages/components/src/icon/iconfont/iconMap.ts 100.00% <ø> (ø)
packages/core-browser/src/common/common.command.ts 100.00% <ø> (ø)
packages/core-browser/src/preferences/types.ts 100.00% <ø> (ø)
packages/core-browser/src/toolbar/types.ts 100.00% <ø> (ø)
packages/core-common/src/index.ts 100.00% <ø> (ø)
...ackages/debug/src/browser/debug-session-manager.ts 66.99% <0.00%> (+0.65%) ⬆️
packages/debug/src/browser/debug-session.ts 1.41% <0.00%> (-9.41%) ⬇️
.../src/browser/view/console/debug-console.service.ts 15.42% <0.00%> (ø)
... and 111 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19
Copy link
Copy Markdown
Member

erha19 commented Apr 18, 2023

@shilin8805 功能提交不能上 patch 分支,我指到 main 分支后续跟随 2.24.0 发布

@erha19 erha19 changed the base branch from v2.23 to main April 18, 2023 08:58
@erha19 erha19 merged commit b5b8ef1 into opensumi:main Apr 18, 2023
@erha19
Copy link
Copy Markdown
Member

erha19 commented Apr 18, 2023

@shilin8805
Copy link
Copy Markdown
Contributor Author

👌好的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants