Skip to content

fix(theme): foucs first entry theme when then input is not empty #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erha19 merged 1 commit into from
Apr 14, 2023
Merged

fix(theme): foucs first entry theme when then input is not empty #2589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/theme/src/browser/theme.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ export class ThemeContribution implements MenuContribution, CommandContribution,
const themeId = await this.showPickWithPreview(
items,
{
selectIndex: () => defaultSelected,
selectIndex: (lookFor) => (lookFor ? -1 : defaultSelected), // 默认展示当前主题，如果有输入，则选择第一个，否则 selectIndex 一直不变导致显示有问题
placeholder: localize('theme.quickopen.plh'),
},
(value) => {
Expand Down Expand Up @@ -353,7 +353,7 @@ export class ThemeContribution implements MenuContribution, CommandContribution,
const themeId = await this.showPickWithPreview(
items,
{
selectIndex: () => defaultSelected,
selectIndex: (lookFor) => (lookFor ? -1 : defaultSelected),
placeholder: localize('icon.quickopen.plh'),
},
(value) => {
Expand Down