Skip to content

fix: should set renderMarginRevertIcon=false when diffEditor is readOnly#2492

Merged
erha19 merged 1 commit intoopensumi:mainfrom
miserylee:main
Mar 27, 2023
Merged

fix: should set renderMarginRevertIcon=false when diffEditor is readOnly#2492
erha19 merged 1 commit intoopensumi:mainfrom
miserylee:main

Conversation

@miserylee
Copy link
Copy Markdown
Contributor

Types

  • 🎉 New Features
  • 🐛 Bug Fixes
  • 📚 Documentation Changes
  • 💄 Code Style Changes
  • 💄 Style Changes
  • 🪚 Refactors
  • 🚀 Performance Improvements
  • 🏗️ Build System
  • ⏱ Tests
  • 🧹 Chores
  • Other Changes

resolve #2489

Background or solution

Changelog

@github-actions github-actions Bot added the 🐞 bug Something isn't working label Mar 24, 2023
@erha19 erha19 requested a review from Ricbet March 24, 2023 10:23
@erha19
Copy link
Copy Markdown
Member

erha19 commented Mar 24, 2023

@Ricbet 来看一下这个 PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (bd10eba) 57.75% compared to head (5b5166b) 57.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2492      +/-   ##
==========================================
- Coverage   57.75%   57.74%   -0.01%     
==========================================
  Files        1323     1323              
  Lines       83471    83472       +1     
  Branches    17374    17374              
==========================================
- Hits        48205    48198       -7     
- Misses      32045    32052       +7     
- Partials     3221     3222       +1     
Flag Coverage Δ
jsdom 52.76% <0.00%> (-0.01%) ⬇️
node 16.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/editor/src/browser/editor-collection.service.ts 65.39% <0.00%> (-0.17%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit e427fef into opensumi:main Mar 27, 2023
@erha19
Copy link
Copy Markdown
Member

erha19 commented Mar 27, 2023

@miserylee 感谢你的提交,这部分修复将会在 2.24.0 版本发布,如果需要版本进行测试,可以联系我们发布 ~

@erha19 erha19 added this to the 2.24 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 冲突的 compare 视图会展示 revert 图标

3 participants