Skip to content

refactor: refactor file-watcher test case#2463

Merged
erha19 merged 2 commits intomainfrom
feat/file-watcher-test
Mar 22, 2023
Merged

refactor: refactor file-watcher test case#2463
erha19 merged 2 commits intomainfrom
feat/file-watcher-test

Conversation

@pipiiiiii
Copy link
Copy Markdown
Contributor

Types

  • 🪚 Refactors
  • ⏱ Tests

Background or solution

#2354

Changelog

  • change file server watcher to private for every case

@github-actions github-actions Bot added the ⚙️ refactor Refactor code label Mar 22, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (3226e4d) 57.74% compared to head (230b156) 57.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
- Coverage   57.74%   57.74%   -0.01%     
==========================================
  Files        1323     1323              
  Lines       83469    83471       +2     
  Branches    17373    17374       +1     
==========================================
  Hits        48198    48198              
- Misses      32050    32051       +1     
- Partials     3221     3222       +1     
Flag Coverage Δ
jsdom 52.76% <ø> (-0.01%) ⬇️
node 16.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 42e2718 into main Mar 22, 2023
@erha19 erha19 deleted the feat/file-watcher-test branch March 22, 2023 06:37
@bytemain
Copy link
Copy Markdown
Member

/pick to v2.23

@bytemain
Copy link
Copy Markdown
Member

/backport to v2.23

1 similar comment
@bytemain
Copy link
Copy Markdown
Member

/backport to v2.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ refactor Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants