Skip to content

Revert "fix: use bash resolve shellpath"#2347

Merged
bytemain merged 1 commit intomainfrom
revert-2021-fix/use-bash-resolve-shell-path
Mar 3, 2023
Merged

Revert "fix: use bash resolve shellpath"#2347
bytemain merged 1 commit intomainfrom
revert-2021-fix/use-bash-resolve-shell-path

Conversation

@yantze
Copy link
Copy Markdown
Member

@yantze yantze commented Feb 28, 2023

Reverts #2021

如果用戶使用的是 zsh 比如 .zshrc 配置的內容,使用 /bin/bash 将会丢失相关的 PATH 信息。

@github-actions github-actions Bot added the 🐞 bug Something isn't working label Feb 28, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2023

Codecov Report

Base: 57.83% // Head: 57.83% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7c034bd) compared to base (9544725).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2347   +/-   ##
=======================================
  Coverage   57.83%   57.83%           
=======================================
  Files        1322     1322           
  Lines       83236    83237    +1     
  Branches    17333    17334    +1     
=======================================
+ Hits        48139    48140    +1     
  Misses      31895    31895           
  Partials     3202     3202           
Flag Coverage Δ
jsdom 52.80% <0.00%> (-0.01%) ⬇️
node 16.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-node/src/bootstrap/shell-path.ts 82.14% <100.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bytemain
Copy link
Copy Markdown
Member

bytemain commented Mar 3, 2023

你是在 Linux 下发的这个 PR 吗?

"內容" === "内容" // false

这些文字好像不是我们平时使用的文字

@bytemain bytemain merged commit 6cba129 into main Mar 3, 2023
@bytemain bytemain deleted the revert-2021-fix/use-bash-resolve-shell-path branch March 3, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants