Skip to content

feat: toolbar dropdown-button contribute#2312

Merged
erha19 merged 9 commits intomainfrom
feat/ext-dropdown-button
Mar 17, 2023
Merged

feat: toolbar dropdown-button contribute#2312
erha19 merged 9 commits intomainfrom
feat/ext-dropdown-button

Conversation

@hacke2
Copy link
Copy Markdown
Member

@hacke2 hacke2 commented Feb 20, 2023

Types

  • 🎉 New Features

Background or solution

resolve #1740

"kaitianContributes": {
    "toolbar": {
      "actions": [
        {
          "type": "dropdownButton",
          "id": "common-start",
          "command": "common-start.select",
          "options": [
            {
              "label": "运行",
              "value": "run"
            },
            {
              "label": "调试",
              "value": "debug"
            }
          ]
        }
      ]
    }
  },

image

Changelog

Add DropdownButton Component
Add DropdownButton Toolbar contribute

@hacke2 hacke2 requested review from Aaaaash, Ricbet and erha19 February 20, 2023 07:49
@github-actions github-actions Bot added the 🎨 feature feature required label Feb 20, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2023

Codecov Report

Patch coverage: 57.39% and project coverage change: +5.10 🎉

Comparison is base (e580012) 52.73% compared to head (a9482bd) 57.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2312      +/-   ##
==========================================
+ Coverage   52.73%   57.83%   +5.10%     
==========================================
  Files        1322     1324       +2     
  Lines       83271    83380     +109     
  Branches    17331    17363      +32     
==========================================
+ Hits        43914    48226    +4312     
+ Misses      35725    31946    -3779     
+ Partials     3632     3208     -424     
Flag Coverage Δ
jsdom 52.81% <57.39%> (+0.07%) ⬆️
node 16.68% <1.73%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/toolbar/types.ts 100.00% <ø> (ø)
.../extension/src/browser/sumi/contributes/toolbar.ts 29.72% <0.00%> (-5.76%) ⬇️
.../extension/src/browser/sumi/main.thread.toolbar.ts 9.81% <3.84%> (-0.75%) ⬇️
.../extension/src/hosted/api/sumi/ext.host.toolbar.ts 83.72% <75.86%> (-1.07%) ⬇️
packages/components/src/index.ts 100.00% <100.00%> (ø)
...kages/core-browser/src/toolbar/components/index.ts 100.00% <100.00%> (ø)
packages/extension/src/common/sumi/toolbar.ts 100.00% <100.00%> (ø)
packages/core-browser/src/utils/env.ts 25.00% <0.00%> (-31.25%) ⬇️
...ser/components/scm-resource-tree/scm-tree-model.ts 38.46% <0.00%> (-4.40%) ⬇️
packages/editor/src/browser/diff/index.ts 90.56% <0.00%> (-3.72%) ⬇️
... and 135 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread packages/components/src/dropdown/dropdown-button.tsx
Comment thread packages/components/src/button/index.tsx Outdated
Comment thread packages/extension/src/hosted/api/sumi/ext.host.toolbar.ts Outdated
Comment thread packages/core-browser/src/toolbar/components/dropdown-button.tsx Outdated
Comment thread packages/extension/src/common/sumi/toolbar.ts Outdated
Comment thread packages/extension/src/common/sumi/toolbar.ts Outdated
Comment thread packages/extension/src/common/sumi/toolbar.ts
Copy link
Copy Markdown
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit dc17d16 into main Mar 17, 2023
@erha19 erha19 deleted the feat/ext-dropdown-button branch March 17, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] toolbar 贡献点支持 Dropdown Button

3 participants