Skip to content

fix: support collaborationWsPath config#2193

Merged
erha19 merged 1 commit intomainfrom
fix/support-collaboration-wsPath-config
Jan 12, 2023
Merged

fix: support collaborationWsPath config#2193
erha19 merged 1 commit intomainfrom
fix/support-collaboration-wsPath-config

Conversation

@Ricbet
Copy link
Copy Markdown
Member

@Ricbet Ricbet commented Jan 11, 2023

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

新增 collaborationWsPath 配置,解决上游集成方协同模块的通信问题

@Ricbet Ricbet requested review from erha19 and hacke2 January 11, 2023 11:27
@github-actions github-actions Bot added the 🐞 bug Something isn't working label Jan 11, 2023
@Ricbet Ricbet self-assigned this Jan 11, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2023

Codecov Report

Base: 57.80% // Head: 57.80% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d881432) compared to base (cf3e391).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2193      +/-   ##
==========================================
- Coverage   57.80%   57.80%   -0.01%     
==========================================
  Files        1316     1316              
  Lines       83016    83020       +4     
  Branches    17272    17273       +1     
==========================================
  Hits        47987    47987              
- Misses      31834    31838       +4     
  Partials     3195     3195              
Flag Coverage Δ
jsdom 52.75% <100.00%> (-0.01%) ⬇️
node 16.49% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...collaboration/src/browser/collaboration.service.ts 74.39% <100.00%> (+0.64%) ⬆️
...kages/collaboration/src/node/y-websocket-server.ts 80.00% <100.00%> (ø)
packages/utils/src/buffer.ts 29.65% <0.00%> (-2.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 changed the base branch from v2.21 to main January 11, 2023 12:19
@Ricbet Ricbet force-pushed the fix/support-collaboration-wsPath-config branch from 9236447 to d881432 Compare January 11, 2023 14:12
@erha19 erha19 merged commit 9e93127 into main Jan 12, 2023
@erha19 erha19 deleted the fix/support-collaboration-wsPath-config branch January 12, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants