Skip to content

fix: quick open argument#2117

Merged
erha19 merged 2 commits into
mainfrom
fix/quick-open-argument
Dec 26, 2022
Merged

fix: quick open argument#2117
erha19 merged 2 commits into
mainfrom
fix/quick-open-argument

Conversation

@Aaaaash
Copy link
Copy Markdown
Member

@Aaaaash Aaaaash commented Dec 24, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

@github-actions github-actions Bot added the 🐞 bug Something isn't working label Dec 24, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 24, 2022

Codecov Report

Base: 16.81% // Head: 57.72% // Increases project coverage by +40.90% 🎉

Coverage data is based on head (92db5f6) compared to base (7ab7347).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2117       +/-   ##
===========================================
+ Coverage   16.81%   57.72%   +40.90%     
===========================================
  Files        1299     1299               
  Lines       81607    81608        +1     
  Branches    17009    17009               
===========================================
+ Hits        13726    47107    +33381     
+ Misses      62012    31368    -30644     
+ Partials     5869     3133     -2736     
Flag Coverage Δ
jsdom 52.55% <100.00%> (?)
node 16.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/common/common.command.ts 100.00% <100.00%> (ø)
...ages/file-service/src/node/file-service-watcher.ts 72.34% <0.00%> (+0.53%) ⬆️
packages/utils/src/path.ts 78.19% <0.00%> (+1.08%) ⬆️
packages/utils/src/errors.ts 46.05% <0.00%> (+1.31%) ⬆️
packages/utils/src/map.ts 84.33% <0.00%> (+1.35%) ⬆️
packages/core-browser/src/menu/next/menu-id.ts 100.00% <0.00%> (+1.38%) ⬆️
packages/extension/src/common/vscode/utils.ts 23.72% <0.00%> (+1.69%) ⬆️
packages/editor/src/common/editor.ts 100.00% <0.00%> (+2.08%) ⬆️
packages/task/src/browser/problem-line-matcher.ts 2.21% <0.00%> (+2.21%) ⬆️
...ension/src/common/vscode/testing/testCollection.ts 2.55% <0.00%> (+2.55%) ⬆️
... and 790 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread packages/quick-open/src/browser/quick-open.contribution.ts
@erha19 erha19 merged commit 4703237 into main Dec 26, 2022
@erha19 erha19 deleted the fix/quick-open-argument branch December 26, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants