Skip to content

fix: save file diff error#2113

Merged
erha19 merged 2 commits intomainfrom
fix/file-save-diff-error
Dec 27, 2022
Merged

fix: save file diff error#2113
erha19 merged 2 commits intomainfrom
fix/file-save-diff-error

Conversation

@Aaaaash
Copy link
Copy Markdown
Member

@Aaaaash Aaaaash commented Dec 23, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

@github-actions github-actions Bot added the 🐞 bug Something isn't working label Dec 23, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 23, 2022

Codecov Report

Base: 57.72% // Head: 57.72% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c1cba78) compared to base (d93b6d3).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
- Coverage   57.72%   57.72%   -0.01%     
==========================================
  Files        1299     1299              
  Lines       81607    81611       +4     
  Branches    17009    17009              
==========================================
+ Hits        47106    47107       +1     
- Misses      31368    31370       +2     
- Partials     3133     3134       +1     
Flag Coverage Δ
jsdom 52.54% <83.33%> (-0.01%) ⬇️
node 16.82% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...file-service/src/node/disk-file-system.provider.ts 78.71% <83.33%> (+0.25%) ⬆️
...kages/theme/src/browser/workbench.theme.service.ts 71.38% <0.00%> (-0.58%) ⬇️
...erences/src/browser/preference-settings.service.ts 76.41% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread packages/file-service/src/node/disk-file-system.provider.ts Outdated
@erha19 erha19 merged commit 19ffdf1 into main Dec 27, 2022
@erha19 erha19 deleted the fix/file-save-diff-error branch December 27, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants