Skip to content

refactor: remove DeprecatedRecycleTree on comment module#2109

Merged
erha19 merged 2 commits intomainfrom
refactor/remove-deprecated-recycle-tree-on-comment-module
Dec 23, 2022
Merged

refactor: remove DeprecatedRecycleTree on comment module#2109
erha19 merged 2 commits intomainfrom
refactor/remove-deprecated-recycle-tree-on-comment-module

Conversation

@erha19
Copy link
Copy Markdown
Member

@erha19 erha19 commented Dec 22, 2022

Types

  • 🪚 Refactors

Background or solution

统一评论面板 Tree 组件样式,修复部分样式问题,同时移除废弃的 DeprecatedRecycleTree 组件

相关 Issue: #592

Before:

image

After:
image

Changelog

remove DeprecatedRecycleTree on comment module

@github-actions github-actions Bot added the ⚙️ refactor Refactor code label Dec 22, 2022
@erha19 erha19 changed the title WIP: refactor: remove DeprecatedRecycleTree on comment module refactor: remove DeprecatedRecycleTree on comment module Dec 22, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2022

Codecov Report

Base: 57.73% // Head: 57.62% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (d12ee43) compared to base (21fe449).
Patch coverage: 41.62% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2109      +/-   ##
==========================================
- Coverage   57.73%   57.62%   -0.11%     
==========================================
  Files        1291     1295       +4     
  Lines       81154    81423     +269     
  Branches    16947    16987      +40     
==========================================
+ Hits        46856    46924      +68     
- Misses      31179    31361     +182     
- Partials     3119     3138      +19     
Flag Coverage Δ
jsdom 52.44% <41.62%> (-0.09%) ⬇️
node 16.85% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../comments/src/browser/comments-feature.registry.ts 66.66% <ø> (-4.77%) ⬇️
packages/comments/src/common/index.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...es/comments/src/browser/tree/tree-model.service.ts 10.86% <10.86%> (ø)
...ges/comments/src/browser/tree/tree-node.defined.ts 56.25% <56.25%> (ø)
packages/comments/src/browser/comments.service.ts 49.59% <72.50%> (-3.21%) ⬇️
packages/comments/src/browser/comments-thread.ts 76.04% <90.00%> (+0.27%) ⬆️
packages/comments/src/browser/index.ts 100.00% <100.00%> (ø)
...ion/src/browser/vscode/api/main.thread.comments.ts 67.75% <100.00%> (+0.72%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit d93b6d3 into main Dec 23, 2022
@erha19 erha19 deleted the refactor/remove-deprecated-recycle-tree-on-comment-module branch December 23, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ refactor Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants