Skip to content

refactor: replace DeprecatedRecycleTree on Search view#2102

Merged
erha19 merged 8 commits intomainfrom
refactor/remove-deprecated-recycle-tree-on-search-panel
Dec 23, 2022
Merged

refactor: replace DeprecatedRecycleTree on Search view#2102
erha19 merged 8 commits intomainfrom
refactor/remove-deprecated-recycle-tree-on-search-panel

Conversation

@erha19
Copy link
Copy Markdown
Member

@erha19 erha19 commented Dec 20, 2022

Types

  • 🪚 Refactors

Background or solution

统一搜索面板 Tree 组件样式,修复部分搜索面板问题,同时移除废弃的 DeprecatedRecycleTree 组件,修改内容如下:

  1. 移除 DeprecatedRecycleTree 的使用,使用统一的 RecycleTree 组件
  2. 移除 Search 面板中使用的 mobx,采取纯事件驱动渲染
  3. 修复搜索面板偶现的搜索内容为空的问题(实际有内容)
  4. 修正 Search 面板中 ContextKey 的设置逻辑

相关 Issue: #592

image

Changelog

replace DeprecatedRecycleTree on Search view

@github-actions github-actions Bot added the ⚙️ refactor Refactor code label Dec 20, 2022
@erha19 erha19 changed the title WIP: refactor: replace DeprecatedRecycleTree on Search view refactor: replace DeprecatedRecycleTree on Search view Dec 21, 2022
@erha19
Copy link
Copy Markdown
Member Author

erha19 commented Dec 21, 2022

暂时完成第一阶段改造,重构内容如下:

  1. 移除 DeprecatedRecycleTree 的使用,使用统一的 RecycleTree 组件
  2. 移除 Search 面板中使用的 mobx,采取纯事件驱动渲染
  3. 修复搜索面板偶现的搜索内容为空的问题(实际有内容)
  4. 修正 Search 面板中 ContextKey 的设置逻辑

@erha19 erha19 added this to the 2.22 milestone Dec 21, 2022
@erha19 erha19 force-pushed the refactor/remove-deprecated-recycle-tree-on-search-panel branch from fb6b512 to 6cb6bca Compare December 21, 2022 09:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 22, 2022

Codecov Report

Base: 57.74% // Head: 57.77% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (5fe06e7) compared to base (dbbb622).
Patch coverage: 43.82% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2102      +/-   ##
==========================================
+ Coverage   57.74%   57.77%   +0.02%     
==========================================
  Files        1291     1297       +6     
  Lines       81120    81468     +348     
  Branches    16931    16986      +55     
==========================================
+ Hits        46846    47071     +225     
- Misses      31155    31273     +118     
- Partials     3119     3124       +5     
Flag Coverage Δ
jsdom 52.59% <43.43%> (+0.05%) ⬆️
node 16.84% <0.96%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/components/src/recycle-tree/types/watcher.ts 100.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
...line/src/browser/services/outline-model.service.ts 55.69% <ø> (+0.98%) ⬆️
...ages/search/src/browser/tree/tree-model.service.ts 12.86% <12.86%> (ø)
...ew/variables/debug-variables-tree.model.service.ts 58.22% <20.00%> (-0.93%) ⬇️
...r/view/console/debug-console-tree.model.service.ts 70.38% <40.00%> (-0.85%) ⬇️
...owser/view/watch/debug-watch-tree.model.service.ts 63.96% <40.00%> (-0.75%) ⬇️
...ges/search/src/browser/tree/search-tree.service.ts 49.36% <49.36%> (ø)
...kages/search/src/browser/tree/tree-node.defined.ts 61.11% <61.11%> (ø)
packages/search/src/browser/search.service.ts 49.76% <63.26%> (+7.30%) ⬆️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 force-pushed the refactor/remove-deprecated-recycle-tree-on-search-panel branch from 6fc43d6 to 3629982 Compare December 22, 2022 02:58
Comment thread packages/search/src/browser/search.contribution.ts Outdated
Comment thread packages/i18n/src/common/en-US.lang.ts Outdated
Copy link
Copy Markdown
Member

@yantze yantze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 4e5fc28 into main Dec 23, 2022
@erha19 erha19 deleted the refactor/remove-deprecated-recycle-tree-on-search-panel branch December 23, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ refactor Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants