feat: optimize editor updateContent logic#2097
Merged
Merged
Conversation
Codecov ReportBase: 57.75% // Head: 57.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2097 +/- ##
==========================================
- Coverage 57.75% 57.73% -0.03%
==========================================
Files 1291 1291
Lines 81118 81154 +36
Branches 16931 16938 +7
==========================================
+ Hits 46848 46852 +4
- Misses 31152 31184 +32
Partials 3118 3118
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
erha19
approved these changes
Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
优化文件差量修改时Monaco编辑器的响应逻辑。
Background or solution
OpenSumi在查看日志文件这一类文件末尾会一直增加新文本的场景时,每次末尾文本的增加都会导致Monaco编辑器的全部刷新,进而造成整个编辑器的Log日志高亮闪烁。
因此需要在日志刷新写到编辑器之前增加一个diff逻辑,来保证这类在文件末尾不断新增的文本的日志场景能有不错的阅读体验,避免全局的编辑器闪烁。
视频演示:
Before:
default.mp4
After:
default.mp4
Changelog