Skip to content

feat: support more ActionButton icon expression#1986

Merged
erha19 merged 2 commits intomainfrom
fix/scm/action-button-icon
Nov 21, 2022
Merged

feat: support more ActionButton icon expression#1986
erha19 merged 2 commits intomainfrom
fix/scm/action-button-icon

Conversation

@erha19
Copy link
Copy Markdown
Member

@erha19 erha19 commented Nov 17, 2022

Types

  • 🎉 New Features

Background or solution

close #1983.

同时支持了动态图标表达式:

Kapture 2022-11-17 at 18 50 27

Changelog

support more ActionButton icon expression

@github-actions github-actions Bot added the 🎨 feature feature required label Nov 17, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 17, 2022

Codecov Report

Base: 57.49% // Head: 57.49% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (ad6df59) compared to base (85aff8c).
Patch coverage: 22.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
- Coverage   57.49%   57.49%   -0.01%     
==========================================
  Files        1286     1286              
  Lines       80543    80552       +9     
  Branches    16853    16853              
==========================================
- Hits        46311    46310       -1     
- Misses      31117    31126       +9     
- Partials     3115     3116       +1     
Flag Coverage Δ
jsdom 52.24% <22.22%> (-0.01%) ⬇️
node 15.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ension/src/browser/extension-management.service.ts 44.59% <22.22%> (-3.10%) ⬇️
packages/utils/src/buffer.ts 33.13% <0.00%> (-1.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread packages/extension/src/browser/extension-management.service.ts
Copy link
Copy Markdown
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit df5ab26 into main Nov 21, 2022
@erha19 erha19 deleted the fix/scm/action-button-icon branch November 21, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ActionButton 图标解析存在问题

3 participants