Skip to content

fix: 解决代码片段(Snippets)prefix 不支持数组的问题#1891

Merged
erha19 merged 1 commit intoopensumi:mainfrom
shilin8805:fix/snippet-prefix
Nov 2, 2022
Merged

fix: 解决代码片段(Snippets)prefix 不支持数组的问题#1891
erha19 merged 1 commit intoopensumi:mainfrom
shilin8805:fix/snippet-prefix

Conversation

@shilin8805
Copy link
Copy Markdown
Contributor

@shilin8805 shilin8805 commented Nov 1, 2022

Types

  • 🐛 Bug Fixes

Background or solution

vscode中的snippets代码片段属性prefix支持数组,但是opensumi中不支持

Changelog

调整 monaco 代码,使代码片段 prefix 属性支持数组

@erha19 erha19 changed the title 解决代码片段(Snippets)prefix不支持数组的问题。 fix: 解决代码片段(Snippets)prefix不支持数组的问题。 Nov 1, 2022
@github-actions github-actions Bot added the 🐞 bug Something isn't working label Nov 1, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 1, 2022

Codecov Report

Base: 57.64% // Head: 57.64% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (3948d77) compared to base (2805ccd).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
- Coverage   57.64%   57.64%   -0.01%     
==========================================
  Files        1284     1284              
  Lines       80422    80426       +4     
  Branches    16832    16834       +2     
==========================================
  Hits        46361    46361              
- Misses      30980    30983       +3     
- Partials     3081     3082       +1     
Flag Coverage Δ
jsdom 52.40% <0.00%> (-0.01%) ⬇️
node 15.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aco/src/browser/monaco-snippet-suggest-provider.ts 23.25% <0.00%> (-0.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bytemain @Ricbet have a look, it looks good for me.

@erha19 erha19 changed the title fix: 解决代码片段(Snippets)prefix不支持数组的问题。 fix: 解决代码片段(Snippets)prefix 不支持数组的问题。 Nov 2, 2022
Copy link
Copy Markdown
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 changed the title fix: 解决代码片段(Snippets)prefix 不支持数组的问题。 fix: 解决代码片段(Snippets)prefix 不支持数组的问题 Nov 2, 2022
@erha19 erha19 merged commit 4e843d3 into opensumi:main Nov 2, 2022
@erha19
Copy link
Copy Markdown
Member

erha19 commented Nov 8, 2022

/publish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants