Skip to content

refactor: 不重复初始化文件树#1874

Merged
erha19 merged 3 commits intomainfrom
refactor/do-not-duplicate-init-tree
Oct 31, 2022
Merged

refactor: 不重复初始化文件树#1874
erha19 merged 3 commits intomainfrom
refactor/do-not-duplicate-init-tree

Conversation

@Aaaaash
Copy link
Copy Markdown
Member

@Aaaaash Aaaaash commented Oct 28, 2022

Types

  • 🚀 Performance Improvements

Background or solution

Changelog

@github-actions github-actions Bot added the ⚙️ refactor Refactor code label Oct 28, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 28, 2022

Codecov Report

Base: 57.63% // Head: 57.66% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (57dc0f5) compared to base (75511a4).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1874      +/-   ##
==========================================
+ Coverage   57.63%   57.66%   +0.03%     
==========================================
  Files        1284     1284              
  Lines       80389    80401      +12     
  Branches    16823    16826       +3     
==========================================
+ Hits        46333    46366      +33     
+ Misses      30975    30958      -17     
+ Partials     3081     3077       -4     
Flag Coverage Δ
jsdom 52.42% <83.33%> (+0.02%) ⬆️
node 15.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/components/src/recycle-tree/tree/Tree.ts 90.47% <ø> (-0.83%) ⬇️
...ew/variables/debug-variables-tree.model.service.ts 59.14% <0.00%> (ø)
...omponents/src/recycle-tree/tree/model/TreeModel.ts 77.14% <100.00%> (+2.94%) ⬆️
...line/src/browser/services/outline-model.service.ts 54.71% <100.00%> (ø)
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...ackages/debug/src/browser/debug-session-manager.ts 66.44% <0.00%> (-0.55%) ⬇️
...-layout/src/browser/accordion/accordion.service.ts 64.70% <0.00%> (-0.08%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 60.07% <0.00%> (-0.06%) ⬇️
packages/debug/src/browser/debug-session.ts 10.84% <0.00%> (ø)
...kages/components/src/recycle-tree/tree/TreeNode.ts 71.67% <0.00%> (+0.21%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread packages/components/src/recycle-tree/tree/model/TreeModel.ts
@erha19 erha19 changed the title refactor: (wip) 不重复初始化文件树 refactor: 不重复初始化文件树 Oct 31, 2022
Copy link
Copy Markdown
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit b806686 into main Oct 31, 2022
@erha19 erha19 deleted the refactor/do-not-duplicate-init-tree branch October 31, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ refactor Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants