feat: implement TestController refreshHandler API#1865
Merged
Conversation
Closed
2 tasks
ebbe2e9 to
0fac67a
Compare
Codecov ReportBase: 57.63% // Head: 57.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
==========================================
- Coverage 57.63% 57.62% -0.01%
==========================================
Files 1284 1284
Lines 80389 80406 +17
Branches 16823 16827 +4
==========================================
+ Hits 46332 46334 +2
- Misses 30976 30988 +12
- Partials 3081 3084 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
|
@Ricbet 这个加点单侧吧,放到 2.22 上发了 |
Member
|
Unit Test will be resolved by #1878. |
erha19
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
背景: 默认情况下 Testing 是没有提供刷新操作的,需要插件自己往 workbench.view.testing 贡献点上注册刷新按钮,但这会导致 UI 上的冲突(比如会出现俩刷新按钮)
所以在 TestController 提供了 refreshHandler 的 API 方法,一旦实现了该方法,那么就会在如图所示的地方只出现一个刷新按钮

Changelog
实现 TestController.refreshHandler API