Skip to content

feat: implement TestController refreshHandler API#1865

Merged
erha19 merged 1 commit intomainfrom
feat/implement-testController-refreshHandler
Nov 1, 2022
Merged

feat: implement TestController refreshHandler API#1865
erha19 merged 1 commit intomainfrom
feat/implement-testController-refreshHandler

Conversation

@Ricbet
Copy link
Copy Markdown
Member

@Ricbet Ricbet commented Oct 27, 2022

Types

  • 🎉 New Features

Background or solution

背景: 默认情况下 Testing 是没有提供刷新操作的,需要插件自己往 workbench.view.testing 贡献点上注册刷新按钮,但这会导致 UI 上的冲突(比如会出现俩刷新按钮)

所以在 TestController 提供了 refreshHandler 的 API 方法,一旦实现了该方法,那么就会在如图所示的地方只出现一个刷新按钮
image

Changelog

实现 TestController.refreshHandler API

@Ricbet Ricbet requested review from Aaaaash, erha19 and hacke2 October 27, 2022 11:51
@Ricbet Ricbet self-assigned this Oct 27, 2022
@github-actions github-actions Bot added the 🎨 feature feature required label Oct 27, 2022
@Ricbet Ricbet linked an issue Oct 27, 2022 that may be closed by this pull request
2 tasks
@Ricbet Ricbet force-pushed the feat/implement-testController-refreshHandler branch from ebbe2e9 to 0fac67a Compare October 27, 2022 11:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2022

Codecov Report

Base: 57.63% // Head: 57.62% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0fac67a) compared to base (e8756c1).
Patch coverage: 11.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1865      +/-   ##
==========================================
- Coverage   57.63%   57.62%   -0.01%     
==========================================
  Files        1284     1284              
  Lines       80389    80406      +17     
  Branches    16823    16827       +4     
==========================================
+ Hits        46332    46334       +2     
- Misses      30976    30988      +12     
- Partials     3081     3084       +3     
Flag Coverage Δ
jsdom 52.38% <11.11%> (-0.01%) ⬇️
node 15.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/contextkey/testing.ts 0.00% <0.00%> (ø)
...tension/src/hosted/api/vscode/ext.host.api.impl.ts 91.95% <0.00%> (ø)
.../extension/src/hosted/api/vscode/ext.host.tests.ts 6.03% <0.00%> (-0.10%) ⬇️
...ension/src/browser/vscode/api/main.thread.tests.ts 16.32% <21.42%> (-0.53%) ⬇️
packages/utils/src/strings.ts 39.47% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19
Copy link
Copy Markdown
Member

erha19 commented Oct 28, 2022

@Ricbet 这个加点单侧吧,放到 2.22 上发了

@erha19 erha19 modified the milestones: 2.21, 2.22 Oct 28, 2022
@erha19
Copy link
Copy Markdown
Member

erha19 commented Nov 1, 2022

Unit Test will be resolved by #1878.

@erha19 erha19 merged commit cc3db73 into main Nov 1, 2022
@erha19 erha19 deleted the feat/implement-testController-refreshHandler branch November 1, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] TEST API

2 participants