Skip to content

fix: improve extension installing UX and support unstall#1855

Merged
erha19 merged 2 commits intomainfrom
fix/extension-manager/install-extension-ux
Oct 27, 2022
Merged

fix: improve extension installing UX and support unstall#1855
erha19 merged 2 commits intomainfrom
fix/extension-manager/install-extension-ux

Conversation

@erha19
Copy link
Copy Markdown
Member

@erha19 erha19 commented Oct 26, 2022

Types

  • 🐛 Bug Fixes

Background or solution

close #1845.

Kapture.2022-10-26.at.17.44.52.mp4

Changelog

improve extension installing UX and support unstall

@github-actions github-actions Bot added the 🐞 bug Something isn't working label Oct 26, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 26, 2022

Codecov Report

Base: 57.57% // Head: 57.56% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1c12e41) compared to base (69ba8b8).
Patch coverage: 10.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
- Coverage   57.57%   57.56%   -0.02%     
==========================================
  Files        1285     1285              
  Lines       80236    80275      +39     
  Branches    16811    16818       +7     
==========================================
+ Hits        46196    46207      +11     
- Misses      30961    30986      +25     
- Partials     3079     3082       +3     
Flag Coverage Δ
jsdom 52.31% <10.63%> (-0.02%) ⬇️
node 15.89% <4.25%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nsion-manager/src/browser/vsx-extension.service.ts 0.00% <0.00%> (ø)
packages/extension-manager/src/common/index.ts 0.00% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...nsion/src/browser/extension-instance-management.ts 62.68% <50.00%> (-1.83%) ⬇️
packages/core-common/src/const/application.ts 100.00% <100.00%> (ø)
packages/extension/src/browser/types.ts 100.00% <100.00%> (ø)
packages/task/src/common/index.ts 100.00% <0.00%> (ø)
packages/terminal-next/src/common/index.ts 100.00% <0.00%> (ø)
...nal-next/src/browser/contribution/terminal.menu.ts 0.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@yantze yantze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit c3ea64a into main Oct 27, 2022
@erha19 erha19 deleted the fix/extension-manager/install-extension-ux branch October 27, 2022 03:37
@erha19
Copy link
Copy Markdown
Member Author

erha19 commented Oct 27, 2022

close #1836.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 插件市场点击安装不能安装插件

2 participants