fix: localEcho exclude program config type defense#1800
Merged
Conversation
erha19
reviewed
Oct 18, 2022
Codecov ReportBase: 57.62% // Head: 57.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
- Coverage 57.62% 57.61% -0.01%
==========================================
Files 1285 1285
Lines 80171 80175 +4
Branches 16793 16796 +3
==========================================
- Hits 46198 46195 -3
- Misses 30903 30909 +6
- Partials 3070 3071 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Aaaaash
previously approved these changes
Oct 18, 2022
erha19
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Fix: 某些奇怪的情况下 用户会无意中把这个字段设置成字符串 导致终端crash
Background or solution
用户反馈终端不可用,排查发现是 localEchoExcludePrograms.map 不可用导致的。然后发现设置中此项变成了字符串,因此需要做个防御。
Changelog