Skip to content

fix: localEcho exclude program config type defense#1800

Merged
erha19 merged 2 commits intomainfrom
fix_typeahead_config_retrox
Oct 19, 2022
Merged

fix: localEcho exclude program config type defense#1800
erha19 merged 2 commits intomainfrom
fix_typeahead_config_retrox

Conversation

@life2015
Copy link
Copy Markdown
Member

@life2015 life2015 commented Oct 18, 2022

Types

Fix: 某些奇怪的情况下 用户会无意中把这个字段设置成字符串 导致终端crash

  • 🐛 Bug Fixes

Background or solution

用户反馈终端不可用,排查发现是 localEchoExcludePrograms.map 不可用导致的。然后发现设置中此项变成了字符串,因此需要做个防御。

Changelog

  • add localEcho exclude program config type defense

@life2015 life2015 requested a review from Aaaaash October 18, 2022 07:42
@life2015 life2015 self-assigned this Oct 18, 2022
Comment thread packages/terminal-next/src/browser/terminal.client.ts Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 18, 2022

Codecov Report

Base: 57.62% // Head: 57.61% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0b5d1e2) compared to base (742d745).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
- Coverage   57.62%   57.61%   -0.01%     
==========================================
  Files        1285     1285              
  Lines       80171    80175       +4     
  Branches    16793    16796       +3     
==========================================
- Hits        46198    46195       -3     
- Misses      30903    30909       +6     
- Partials     3070     3071       +1     
Flag Coverage Δ
jsdom 52.36% <0.00%> (-0.01%) ⬇️
node 15.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/terminal-next/src/browser/terminal.client.ts 72.77% <0.00%> (-0.85%) ⬇️
packages/utils/src/buffer.ts 33.13% <0.00%> (-1.75%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Aaaaash
Aaaaash previously approved these changes Oct 18, 2022
@erha19 erha19 changed the title fix: localEcho exclue program config type defense fix: localEcho exclude program config type defense Oct 19, 2022
@erha19 erha19 merged commit 8981be8 into main Oct 19, 2022
@erha19 erha19 deleted the fix_typeahead_config_retrox branch October 19, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants