Skip to content

build: fix build#1759

Merged
erha19 merged 1 commit intomainfrom
build/fix-build-2.20
Oct 10, 2022
Merged

build: fix build#1759
erha19 merged 1 commit intomainfrom
build/fix-build-2.20

Conversation

@bytemain
Copy link
Copy Markdown
Member

@bytemain bytemain commented Oct 9, 2022

Types

  • 🏗️ Build System

Background or solution

packages/remote-cli 这个包是 private 的,然后无法被 lerna 更新到 2.20.3,所以在 core 里 run init 会报错

Changelog

fix build

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 9, 2022

Codecov Report

Base: 57.60% // Head: 57.76% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (7f63379) compared to base (ea11ad3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1759      +/-   ##
==========================================
+ Coverage   57.60%   57.76%   +0.16%     
==========================================
  Files        1258     1281      +23     
  Lines       78553    79654    +1101     
  Branches    16456    16676     +220     
==========================================
+ Hits        45247    46013     +766     
- Misses      30303    30612     +309     
- Partials     3003     3029      +26     
Flag Coverage Δ
jsdom 52.61% <ø> (+0.20%) ⬆️
node 15.87% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...xtension/src/hosted/api/vscode/ext.host.theming.ts 73.33% <0.00%> (-26.67%) ⬇️
packages/utils/src/date.ts 80.00% <0.00%> (-20.00%) ⬇️
packages/editor/src/browser/history/index.ts 65.71% <0.00%> (-18.04%) ⬇️
packages/core-browser/src/layout/layout.ts 42.50% <0.00%> (-16.48%) ⬇️
packages/theme/src/common/theme.service.ts 67.94% <0.00%> (-7.06%) ⬇️
...ages/quick-open/src/browser/quick-input-service.ts 65.11% <0.00%> (-2.39%) ⬇️
packages/extension/src/common/vscode/converter.ts 38.91% <0.00%> (-2.17%) ⬇️
packages/terminal-next/src/browser/xterm.ts 82.35% <0.00%> (-0.55%) ⬇️
packages/electron-basic/src/browser/index.ts 73.26% <0.00%> (-0.48%) ⬇️
packages/theme/src/browser/theme-data.ts 62.95% <0.00%> (-0.36%) ⬇️
... and 116 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit ae02183 into main Oct 10, 2022
@erha19 erha19 deleted the build/fix-build-2.20 branch October 10, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants