Use secure cookies only when HTTPS is expected#6430
Merged
tomhughes merged 2 commits intoopenstreetmap:masterfrom Oct 6, 2025
Merged
Use secure cookies only when HTTPS is expected#6430tomhughes merged 2 commits intoopenstreetmap:masterfrom
tomhughes merged 2 commits intoopenstreetmap:masterfrom
Conversation
This is particularly important if running system tests with a remote Selenium instance. HTTPS and localhost are considered "secure" for this purpose, while a remote Selenium will connect to the app with HTTP instead.
Member
|
Looks good to me, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
{ secure: true, path: "/", samesite: "lax" }.Cookies.withAttributes, creating a preset that I have placed atOSM.cookies.expiresleft in place as it does change in each instance.secure: trueto only apply when HTTPS is expected. This is, whenSettings.server_protocol == "https".This change is extracted from #6424. Over there it was done so that system tests work with remote Selenium.