Avoid modifier release immediately followed by modifier press#1810
Merged
user202729 merged 1 commit intoopensteno:mainfrom Jan 17, 2026
Merged
Conversation
97c3936 to
2272f0b
Compare
mkrnr
requested changes
Jan 15, 2026
Contributor
mkrnr
left a comment
There was a problem hiding this comment.
The change looks good to me, thanks!
Just a small one: better move the news file to "linux" instead of "core".
2272f0b to
3362363
Compare
mkrnr
approved these changes
Jan 17, 2026
Contributor
mkrnr
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Feel free to merge when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
If the user wants to type an all-uppercase string e.g.
ABC,before this change, the following events will be sent
now we get the following, which is much more reasonable
I recall some issues (laggy Discord on Firefox?) that is suspected to be caused by this behavior (which is likely enough if some heavy logic are executed on shift key press/release), but I can't find the bug report anymore.
Caveat: not sure if news entry should go into linux or core, since I've only implemented it for linux.
Pull Request Checklist