Update posthog lib#1701
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PostHog Ruby SDK from version 2.5.1 to 3.5.4 and significantly enhances the analytics tracking implementation. The changes centralize event logging logic in a new OXPosthog.log method and expand the user and school properties being tracked.
Changes:
- Updated PostHog Ruby SDK from v2.5.1 to v3.5.4 with corresponding API changes
- Centralized analytics logging with new
OXPosthog.logandOXPosthog.identify_schoolmethods - Expanded user and school property tracking in both frontend and backend implementations
- Improved event naming consistency (e.g., using structured events with provider properties instead of event name variations)
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Gemfile | Pin PostHog Ruby gem to version ~> 3.5 |
| Gemfile.lock | Update PostHog Ruby from 2.5.1 to 3.5.4 and concurrent-ruby dependency |
| lib/posthog.rb | Add memoization, update API for v3, add centralized log and identify_school methods with comprehensive user/school properties |
| app/controllers/application_controller.rb | Refactor log_posthog to delegate to centralized OXPosthog.log method |
| app/controllers/newflow/social_auth_controller.rb | Update event names to use structured properties instead of string interpolation, add new signup completion event |
| app/controllers/newflow/password_management_controller.rb | Move password reset event tracking from form view to actual email send action |
| app/views/layouts/_posthog.html.erb | Add session recording config, expand tracked properties, reorganize identify/group calls, use JavaScript escaping for school properties |
| app/views/layouts/admin.html.erb | Conditionally exclude PostHog in test environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the PostHog Ruby SDK from version 2.5.1 to 3.5.4 and significantly enhances the analytics tracking implementation. The changes centralize event logging logic in a new OXPosthog.log method and expand the user and school properties being tracked.
Changes: