TRT-2373: Revert "Revert "Merge pull request openshift#30269 from hongkailiu/OTA-1626"" #30426
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@hongkailiu: This pull request references OTA-1626 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 9d8724d
|
openshift-merge-robot
added
the
needs-rebase
…A-1626"" This reverts commit aba036a.
hongkailiu
force-pushed
the
30269-revert-fix
branch
from
9d8724d to
5480f43
Compare
openshift-merge-robot
removed
the
needs-rebase
Otherwise, it will screw up the aggregated job [1] when there is a failure for the same case. ```text Message: Passed 0 times, failed 1 times, skipped 0 times: we require at least 6 attempts to have a chance at success name: '[Monitor:cluster-version-checker][bz-Networking] clusteroperator/network must complete version change under 30 minutes' testsuitename: openshift-tests-upgrade summary: 'Passed 0 times, failed 1 times, skipped 0 times: we require at least 6 attempts to have a chance at success' passes: [] failures: - jobrunid: "1981587413155188736" humanurl: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade/1981587413155188736 gcsartifacturl: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade/1981587413155188736/artifacts skips: [] ``` [1]. https://prow.ci.openshift.org/view/gs/test-platform-results/logs/aggregated-azure-ovn-upgrade-4.21-micro-release-openshift-release-analysis-aggregator/1981691223231959040
hongkailiu
force-pushed
the
30269-revert-fix
branch
from
5480f43 to
18eadc6
Compare
hongkailiu
changed the title
|
@hongkailiu: This pull request references TRT-2373 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@hongkailiu: This pull request references TRT-2373 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@hongkailiu: This pull request references TRT-2373 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade 10 |
|
@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/04a33270-b338-11f0-9dd5-3d3bbd953e3e-0 |
|
@hongkailiu: This pull request references TRT-2373 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 18eadc6
|
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade 10 Try again. No RELEVANT failure in the previous try. |
|
@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/72cbef90-b387-11f0-93d9-e982bdf39ed1-0 |
Originally, the test name contains the number of minutes as the limited time for CO to update. We have to go through the process/trouble [1] if we need to change the number. Here we use a more general test name to avoid it. [1]. https://github.com/openshift-eng/ci-test-mapping?tab=readme-ov-file#renaming-tests
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu, wking, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The above stanza from #30426 (comment) shows that the tests are there for the success as well. /verified by @hongkailiu |
openshift-ci-robot
added
the
verified
|
@hongkailiu: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@hongkailiu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 51d8436
|
5 participants
Revert aba036a "Revert "Merge pull request #30269 from hongkailiu/OTA-1626"" from #30425.
Add JUnitTestCase for success as well. Otherwise, it will screw up the aggregated job [1] when there is a failure for the same case.
[1]. https://prow.ci.openshift.org/view/gs/test-platform-results/logs/aggregated-azure-ovn-upgrade-4.21-micro-release-openshift-release-analysis-aggregator/1981691223231959040