use the service cert signing project #20314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
Contributor
Author
|
@mfojtik I still don't see the cluster-up directly with the logs collected. This works for me locally. Advice? |
Contributor
Author
|
/retest |
deads2k
force-pushed
the
oc-01-serving-cert
branch
from
f85893d to
c0b7179
Compare
deads2k
force-pushed
the
oc-01-serving-cert
branch
from
c0b7179 to
e1f0b61
Compare
Contributor
Author
|
@mfojtik tried hardcoding the image. We still need to figure out how to fix the logs for this. |
Contributor
Author
|
/retest |
Contributor
|
/cc @petr-muller |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
oc cluster upreliant on the service cert signer project for generating the certs for the apiserver and for injecting the valid CA into the apiservices./assign @mfojtik
@smarterclayton @stevekuznetsov I saw there's a way in CI to stand up a real cluster. Is there a similar thing for oc cluster up I could add to the CI for https://github.com/openshift/service-serving-cert-signer