OCPBUGS-7102: make plugin e2e tests skippable

[perdasilva]

This PR:

• updates the plug-in framework to help make the e2e tests skippable when the plug-in is not enabled
• removes the unit test timebomb
• adds a new make target make update-plugin-deps
• make the new target a dependency of the make vendor target

The CSV Labeler Plug-in test suite included a timebomb to force us to remember to switch the branch of its dependency on
github.com/openshift/cluster-policy-controller, i.e.

olm@release-master -> cluster-policy-controller@master
[email protected] -> [email protected]
[email protected] -> [email protected]
...

Instead of this, I've added a new script that go gets the latest dependency at the particular branch and attached it to the make vendor target. If there are changes here, the verify job will fail and we'll have to update the vendor folder and update the PR.

NOTE verify job will fail due to the removal of the timebomb test: changes to staging - this can be safely overridden

Signed-off-by: perdasilva [email protected]

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dinhxuanvu]

How can I disapprove this? 😉

[perdasilva]

How can I disapprove this? wink

Just say the word, @dinhxuanvu XD

[grokspawn]

/override ci/prow/verify

This is deliberately downstream-only.

[openshift-ci]

@grokspawn: Overrode contexts on behalf of grokspawn: ci/prow/verify

Details

In response to this:

/override ci/prow/verify

This is deliberately downstream-only.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[perdasilva]

/retest

[grokspawn]

/hold for linking with OCPBUGS-7102

[openshift-ci-robot]

@perdasilva: This pull request references Jira Issue OCPBUGS-7102, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR:

• updates the plug-in framework to help make the e2e tests skippable when the plug-in is not enabled
• removes the unit test timebomb
• adds a new make target make update-plugin-deps
• make the new target a dependency of the make vendor target

The CSV Labeler Plug-in test suite included a timebomb to force us to remember to switch the branch of its dependency on
github.com/openshift/cluster-policy-controller, i.e.

olm@release-master -> cluster-policy-controller@master
[email protected] -> [email protected]
[email protected] -> [email protected]
...

Instead of this, I've added a new script that go gets the latest dependency at the particular branch and attached it to the make vendor target. If there are changes here, the verify job will fail and we'll have to update the vendor folder and update the PR.

NOTE verify job will fail due to the removal of the timebomb test: changes to staging - this can be safely overridden

Signed-off-by: perdasilva [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[grokspawn]

/unhold

[grokspawn]

/test e2e-upgrade

[awgreene]

/retest

[grokspawn]

/retest

[grokspawn]

/retest

[grokspawn]

/retest

[grokspawn]

/retest

[grokspawn]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8aa0b41 and 2 for PR HEAD 4a28010 in total

[grokspawn]

/retest-required

[grokspawn]

/retest

[grokspawn]

/test verify

[grokspawn]

/override ci/prow/verify

Urg. Evidently I have to override for normal CI, and then for pre-merge-check CI as well?

[openshift-ci]

@grokspawn: Overrode contexts on behalf of grokspawn: ci/prow/verify

Details

In response to this:

/override ci/prow/verify

Urg. Evidently I have to override for normal CI, and then for pre-merge-check CI as well?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@perdasilva: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#444

Jira Issue OCPBUGS-7102 has been moved to the MODIFIED state.

Details

In response to this:

This PR:

• updates the plug-in framework to help make the e2e tests skippable when the plug-in is not enabled
• removes the unit test timebomb
• adds a new make target make update-plugin-deps
• make the new target a dependency of the make vendor target

The CSV Labeler Plug-in test suite included a timebomb to force us to remember to switch the branch of its dependency on
github.com/openshift/cluster-policy-controller, i.e.

olm@release-master -> cluster-policy-controller@master
[email protected] -> [email protected]
[email protected] -> [email protected]
...

Instead of this, I've added a new script that go gets the latest dependency at the particular branch and attached it to the make vendor target. If there are changes here, the verify job will fail and we'll have to update the vendor folder and update the PR.

NOTE verify job will fail due to the removal of the timebomb test: changes to staging - this can be safely overridden

Signed-off-by: perdasilva [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@grokspawn: new pull request created: #447

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.