CCM: Remove check for clouds.conf key

The config file stored here was used for the legacy CCM. It is not
relevant to the external CCM and we would like to stop setting it in
[1]. Remove the test, allowing us to do so.

[1] openshift/installer#9601

Signed-off-by: Stephen Finucane <[email protected]>

Author: stephenfin

test/extended/openstack/cloud-provider-config.go

@@ -7,7 +7,6 @@ import (
 	"github.com/gophercloud/gophercloud/v2"
 	"github.com/gophercloud/gophercloud/v2/openstack"
 	"github.com/gophercloud/gophercloud/v2/openstack/config/clouds"
-	ini "gopkg.in/ini.v1"
 
 	g "github.com/onsi/ginkgo/v2"
 	o "github.com/onsi/gomega"
@@ -192,29 +191,18 @@ var _ = g.Describe("[sig-installer][Suite:openshift/openstack] The Openshift", f
 			o.Expect(role.Rules[0].ResourceNames[0]).To(o.Equal(expectedSecretName),
 				"Unexpected resourceName on role %q in %q namespace", openstackCredsRole, systemNamespace)
 
-			g.By(fmt.Sprintf("Getting the openstack auth url from clouds.conf in secret %q in %q namespace",
-				expectedSecretName, systemNamespace))
+			g.By(fmt.Sprintf("Getting the credentials secret %q in %q namespace", expectedSecretName, systemNamespace))
 			secret, err := clientSet.CoreV1().Secrets(systemNamespace).Get(ctx, expectedSecretName, metav1.GetOptions{})
 			o.Expect(err).NotTo(o.HaveOccurred(), "Secret %q not found in %q namespace", expectedSecretName, systemNamespace)
-			conf, err := ini.Load([]byte(secret.Data["clouds.conf"]))
-			o.Expect(err).NotTo(o.HaveOccurred(),
-				"clouds.conf key not found on %q secret in %q namespace", expectedSecretName, systemNamespace)
-			globalSection, err := conf.GetSection("Global")
-			o.Expect(err).NotTo(o.HaveOccurred(),
-				"section Global not found on %q secret in %q namespace", expectedSecretName, systemNamespace)
-			authUrl, err := globalSection.GetKey("auth-url")
-			o.Expect(err).NotTo(o.HaveOccurred(),
-				"property auth-url not found on %q secret in %q namespace", expectedSecretName, systemNamespace)
 
-			g.By(fmt.Sprintf("Getting the openstack auth url from clouds.yaml in secret %q in %q namespace", expectedSecretName, systemNamespace))
+			g.By(fmt.Sprintf("Unmarshalling the clouds.yaml extracted from secret %q in %q namespace", expectedSecretName, systemNamespace))
 			cloudsYaml := make(map[string]map[string]*clouds.Cloud)
 			err = yaml.Unmarshal([]byte(secret.Data["clouds.yaml"]), &cloudsYaml)
 			o.Expect(err).NotTo(o.HaveOccurred(),
 				"Error unmarshaling clouds.yaml on %q secret in %q namespace", expectedSecretName, systemNamespace)
 			clouds := cloudsYaml["clouds"]["openstack"]
 
 			g.By("Compare cloud auth url on secret with openstack API")
-			o.Expect(computeClient.IdentityEndpoint).To(o.HavePrefix(authUrl.Value()), "Unexpected auth url on clouds.conf")
 			o.Expect(computeClient.IdentityEndpoint).To(o.HavePrefix(clouds.AuthInfo.AuthURL), "Unexpected auth url on clouds.yaml")
 
 		})