Skip to content

OSASINFRA-3754: openstack: Stop generating legacy CCM configuration #9601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stephenfin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSASINFRA-3754: openstack: Stop generating legacy CCM configuration #9601

stephenfin wants to merge 1 commit into from

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Mar 26, 2025 •
edited
Loading

The legacy cloud provider read its configuration from the cloud.conf key of the kube-system / openstack-credentials secret. The out-of-tree one uses cloud.conf key of the openshift-cloud-controller-manager / cloud-conf config map. We can therefore remove the former.

Dependencies:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 26, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 26, 2025 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3754 which is a valid jira issue.

Details

In response to this:

[ ] #9194

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 26, 2025 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3754 which is a valid jira issue.

Details

In response to this:

Depends on #9194

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Contributor Author

stephenfin commented Mar 26, 2025

/hold

for dep

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2025
@stephenfin stephenfin force-pushed the remove-legacy-ccm-config branch from 47fe3e8 to 84ec207 Compare March 27, 2025 18:16
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2025
@stephenfin stephenfin force-pushed the remove-legacy-ccm-config branch from 84ec207 to cb8523c Compare April 14, 2025 11:05
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2025
@stephenfin
openstack: Stop generating configuration for legacy cloud provider
4b74292 
The legacy cloud provider read its configuration from the 'cloud.conf'
key of the 'kube-system / openstack-credentials' secret. The out-of-tree
one uses 'cloud.conf' key of the 'openshift-cloud-controller-manager /
cloud-conf' config map. We can therefore remove the former.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin stephenfin force-pushed the remove-legacy-ccm-config branch from cb8523c to 4b74292 Compare April 14, 2025 11:08
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3754 which is a valid jira issue.

Details

In response to this:

The legacy cloud provider read its configuration from the cloud.conf key of the kube-system / openstack-credentials secret. The out-of-tree one uses cloud.conf key of the openshift-cloud-controller-manager / cloud-conf config map. We can therefore remove the former

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin stephenfin changed the title OSASINFRA-3754: Stop generating legacy CCM configuration OSASINFRA-3754: openstack: Stop generating legacy CCM configuration Apr 14, 2025
stephenfin added a commit to shiftstack/openstack-test that referenced this pull request Apr 14, 2025
@stephenfin
CCM: Remove check for clouds.conf key
6da25ff 
The config file stored here was used for the legacy CCM. It is not
relevant to the external CCM and we would like to stop setting it in
[1]. Remove the test, allowing us to do so.

[1] openshift/installer#9601

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin stephenfin mentioned this pull request Apr 14, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3754 which is a valid jira issue.

Details

In response to this:

The legacy cloud provider read its configuration from the cloud.conf key of the kube-system / openstack-credentials secret. The out-of-tree one uses cloud.conf key of the openshift-cloud-controller-manager / cloud-conf config map. We can therefore remove the former.

Dependencies:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 6, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 6, 2025

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 6, 2025
stephenfin added a commit to shiftstack/openstack-test that referenced this pull request Sep 8, 2025
@stephenfin
CCM: Remove check for clouds.conf key
683c3b6 
The config file stored here was used for the legacy CCM. It is not
relevant to the external CCM and we would like to stop setting it in
[1]. Remove the test, allowing us to do so.

[1] openshift/installer#9601

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
Copy link
Contributor Author

stephenfin commented Sep 8, 2025

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 10, 2025 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3754 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.19" instead.

Details

In response to this:

The legacy cloud provider read its configuration from the cloud.conf key of the kube-system / openstack-credentials secret. The out-of-tree one uses cloud.conf key of the openshift-cloud-controller-manager / cloud-conf config map. We can therefore remove the former.

Dependencies:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Contributor Author

stephenfin commented Sep 10, 2025

The dependency is finally merged.

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 10, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 10, 2025
@eshulman2
Copy link
Member

eshulman2 commented Dec 22, 2025

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2025
@eshulman2
Copy link
Member

eshulman2 commented Dec 22, 2025

/retest

1 similar comment
@eshulman2
Copy link
Member

eshulman2 commented Dec 22, 2025

/retest

@eshulman2
Copy link
Member

eshulman2 commented Dec 23, 2025

/test e2e-openstack-proxy

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2025

@stephenfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy 4b74292 link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stephenfin @openshift-ci-robot @openshift-bot @eshulman2 @openshift-merge-robot