Skip to content

Conversation

@Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Apr 25, 2025

Version(s):

gitops-docs-1.15, gitops-docs-1.16, gitops-docs-1.17, gitops-docs-main

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6444

Link to docs preview:

Release Notes for GitOps v1.15.2

QE review:

  • QE has approved this change.

SME review: @Rizwana777, [email protected], [email protected], [email protected]
QE review: @varshab1210
Peer review: @mburke5678

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.15, GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6444

Link to docs preview:

QE review:

  • QE has approved this change.

SME review:
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 25, 2025

🤖 Tue May 20 14:54:38 - Prow CI generated the docs preview:

https://92626--ocpdocs-pr.netlify.app/

@Dhruv-Soni11
Copy link
Contributor Author

/retest

@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-6444 branch 2 times, most recently from db334e1 to 5b57240 Compare April 28, 2025 10:58
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 28, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.15, GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6444

Link to docs preview:

Release Notes for GitOps v1.15.2

QE review:

  • QE has approved this change.

SME review: @Rizwana777, [email protected], [email protected], [email protected]
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 28, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.15, GitOps 1.16

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6444

Link to docs preview:

Release Notes for GitOps v1.15.2

QE review:

  • QE has approved this change.

SME review: @Rizwana777, [email protected], [email protected], [email protected]
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Dhruv-Soni11
Copy link
Contributor Author

/retest

@varshab1210
Copy link

@Dhruv-Soni11 please add RN from https://issues.redhat.com/browse/GITOPS-6150 once its available

@Rizwana777
Copy link

@Dhruv-Soni11 please add RN from https://issues.redhat.com/browse/GITOPS-6150 once its available

https://issues.redhat.com/browse/GITOPS-6150 RN is available, you can add it @Dhruv-Soni11, apologies, I missed mentioning this ticket before, and thanks Varsha for pointing out

@varshab1210
Copy link

LGTM, thanks

Copy link

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dhruv-Soni11
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 7, 2025
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 7, 2025
@mburke5678
Copy link
Contributor

@Dhruv-Soni11 A few comments. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 7, 2025
@Dhruv-Soni11 Dhruv-Soni11 force-pushed the RHDEVDOCS-6444 branch 3 times, most recently from 3b775b0 to 52f77be Compare May 8, 2025 13:08
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 20, 2025
@agantony agantony closed this May 20, 2025
@agantony agantony reopened this May 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue.

In response to this:

Version(s):

gitops-docs-1.15, gitops-docs-1.16, gitops-docs-main

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6444

Link to docs preview:

Release Notes for GitOps v1.15.2

QE review:

  • QE has approved this change.

SME review: @Rizwana777, [email protected], [email protected], [email protected]
QE review: @varshab1210
Peer review: @mburke5678

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Fixed QE review comments

Incorporating SME review comments
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2025
@Dhruv-Soni11 Dhruv-Soni11 changed the base branch from gitops-docs-1.15 to gitops-docs-main May 20, 2025 14:35
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2025

@Dhruv-Soni11: This pull request references RHDEVDOCS-6444 which is a valid jira issue.

In response to this:

Version(s):

gitops-docs-1.15, gitops-docs-1.16, gitops-docs-main

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6444

Link to docs preview:

Release Notes for GitOps v1.15.2

QE review:

  • QE has approved this change.

SME review: @Rizwana777, [email protected], [email protected], [email protected]
QE review: @varshab1210
Peer review: @mburke5678

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 20, 2025
@Dhruv-Soni11
Copy link
Contributor Author

/retest

1 similar comment
@Dhruv-Soni11
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 20, 2025

@Dhruv-Soni11: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc 7cc1477 link true /test validate-asciidoc
ci/prow/validate-portal 7cc1477 link true /test validate-portal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@agantony agantony merged commit 0ed3b7a into openshift:gitops-docs-main May 21, 2025
2 checks passed
@agantony
Copy link
Contributor

@Dhruv-Soni11 Should we also cherry-pick to gitops-docs-1.17?

https://github.com/openshift/openshift-docs/tree/gitops-docs-1.17

@agantony
Copy link
Contributor

/cherrypick gitops-docs-1.17

@agantony
Copy link
Contributor

/cherrypick gitops-docs-1.16

@agantony
Copy link
Contributor

/cherrypick gitops-docs-1.15

@openshift-cherrypick-robot

@agantony: new pull request created: #93602

In response to this:

/cherrypick gitops-docs-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@agantony: new pull request created: #93603

In response to this:

/cherrypick gitops-docs-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@agantony: #92626 failed to apply on top of branch "gitops-docs-1.15":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

In response to this:

/cherrypick gitops-docs-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitops jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.