Skip to content

Update 3.11 for openshift start / hyperkube changes #21268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

Update 3.11 for openshift start / hyperkube changes #21268

merged 1 commit into from
May 28, 2020

Conversation

@adellape
Copy link
Contributor

@adellape adellape commented Apr 17, 2020 •
edited
Loading

Reopening #18691 against enterprise-3.11 branch.

Original description:

Fixes #11751.

Per https://github.com/openshift/origin/releases/tag/v3.11.0:

Preview (internal):

@adellape adellape added this to the Next Release milestone Apr 17, 2020
@adellape
Copy link
Contributor Author

adellape commented Apr 17, 2020

@deads2k Could you PTAL at this 3.11 docs fix re: Origin issue "Remove openshift start node and cut kubelet dependencies" openshift/origin#20344 so we can get it merged? Thank you!

@adellape adellape added peer-review-needed Signifies that the peer review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 17, 2020
@adellape
Copy link
Contributor Author

adellape commented Apr 17, 2020

Adding peer review acks as they were given in the original PR #18691.

@mburke5678 mburke5678 mentioned this pull request May 7, 2020
Closed
@adellape
Copy link
Contributor Author

adellape commented May 7, 2020

@wangke19 Can you take a look at this for QE review, please? Thank you!

@wangke19
Copy link

wangke19 commented May 9, 2020

I will ask @xingxingxia to review together.

xingxingxia
xingxingxia reviewed May 11, 2020
View reviewed changes
Copy link
Contributor

@xingxingxia xingxingxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adellape Hi, LGTM except the inline comments. For some lines which are not in my areas (my areas are Master / Apiserver), already requested related subteams QE inline to double confirm.

install_config/master_node_configuration.adoc Outdated
Comment on lines +22 to +24
Copy link
Contributor

@xingxingxia xingxingxia May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double confirm these other doc pages are desired? I just see these configuration file or configuration maps are in the same doc page ../install_config/master_node_configuration.html

install_config/master_node_configuration.adoc Outdated
Copy link
Contributor

@xingxingxia xingxingxia May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange wording in the in

Copy link
Contributor

@xingxingxia xingxingxia May 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see admin_guide/manage_nodes.adoc#modifying-nodes mentions log level, is this link good?

Copy link
Contributor Author

@adellape adellape May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo and removed link.

install_config/master_node_configuration.adoc Outdated
Comment on lines +1699 to +1701
Copy link
Contributor

@xingxingxia xingxingxia May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to request Networking QE @zhaozhanqi to double confirm for openshift start network

Copy link

@zhaozhanqi zhaozhanqi May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @xingxingxia LGTM

install_config/master_node_configuration.adoc Outdated
Comment on lines +1707 to +1709
Copy link
Contributor

@xingxingxia xingxingxia May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to request Node QE @weinliu @sunilcio to double confirm for the Launch a node server command.

Copy link
Contributor Author

@adellape adellape May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weinliu @sunilcio Are you able to take a look? Thanks!

Copy link

@sunilcio sunilcio May 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adellape lgtm

@adellape adellape merged commit b47528d into openshift:enterprise-3.11 May 28, 2020
@adellape adellape mentioned this pull request May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@zhaozhanqi zhaozhanqi zhaozhanqi left review comments

@xingxingxia xingxingxia xingxingxia left review comments

@sunilcio sunilcio sunilcio left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-3.11 peer-review-done Signifies that the peer review team has reviewed this PR

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@adellape @wangke19 @zhaozhanqi @xingxingxia @sunilcio