modules/*proxy*: httpsProxy supports https:// too

[wking]

Drop the wording from aa39bf3 (#16635), because the network operator explicitly supports both the http and https schemes since openshift/cluster-network-operator@42dbcf8955 (openshift/cluster-network-operator#245), which landed before release-4.2 split off from the network operator's master. This should be backported to 4.2 as well.

CC @bergerhoffer, @danehans

[wking]

And I'm still not clear on why you can't use https for httpProxy, but at least that documented restriction is reflected in the current network-operator validation.

[wking]

Also discussion here. It's not clear to me if/where the "old Git's don't like HTTPS proxies" limitation is tracked outside of the Bugzilla, but I think calling it out in as a build limitation (for some builds? All builds?) makes more sense than saying that it's completely unsupported (maybe folks are running clusters where HTTPS proxies are important but which won't use builds?).

[wking]

Here are the release docs for the limitation. Not sure if/how we want to reference those from this master-branch PR. Thoughts?

[bergerhoffer]

@danehans Since you originally asked for this restriction, can you confirm that it's okay to remove and to update the examples to use https? Thanks!

@wking And I'm on the fence about calling out the git clone known issue in these sections. We don't necessarily repeat the known issues in the relevant doc sections. But if you think it's a big enough restriction that we think users will frequently run into, then we could just mention it right in the descriptions here for httpsProxy.

[kalexand-rh]

@danehans, will you PTAL?

[vikram-redhat]

@danehans BUMP.

@wking can you rebase?

[wking]

#25438 landed the softening, so we don't need this PR anymore.

/close

[openshift-ci-robot]

@wking: Closed this PR.

Details

In response to this:

#25438 landed the softening, so we don't need this PR anymore.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.