Skip to content

Conversation

@elmiko
Copy link
Contributor

@elmiko elmiko commented Apr 2, 2020

This change allows a user to set USE_PODMAN=1 when running the make
command to force usage of podman instead of docker during the build and
image targets.

Also adds a note to the README about the NO_DOCKER and USE_PODMAN
options.

This change allows a user to set `USE_PODMAN=1` when running the make
command to force usage of podman instead of docker during the build and
image targets.

Also adds a note to the README about the `NO_DOCKER` and `USE_PODMAN`
options.
@elmiko
Copy link
Contributor Author

elmiko commented Apr 2, 2020

this is something i've run into several times, i thought it would be nice to have an option for systems that don't have docker available.

i intentionally kept this pr simple, i had thought about adding more automation to detect the presence of podman or absence of docker, but i think this solution is clear and easy to use while preserving the default behavior.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign elmiko
You can assign the PR to them by writing /assign @elmiko in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@elmiko: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit 5f7b54e link /test unit
ci/prow/e2e-aws 5f7b54e link /test e2e-aws
ci/prow/e2e-aws-operator 5f7b54e link /test e2e-aws-operator
ci/prow/e2e-azure 5f7b54e link /test e2e-azure
ci/prow/e2e-aws-scaleup-rhel7 5f7b54e link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elmiko
Copy link
Contributor Author

elmiko commented May 6, 2020

i'm gonna close this and just keep my local changes for podman, perhaps in the future it will make sense to add something like this.

@elmiko elmiko closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants