Skip to content

Conversation

@russellb
Copy link
Contributor

@russellb russellb commented Aug 9, 2019

The "metal3-controller" service account does not exist. Instead, use
the "machine-api-controllers" service account.

The "metal3-controller" service account does not exist.  Instead, use
the "machine-api-controllers" service account.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2019
@stbenjam
Copy link
Member

stbenjam commented Aug 9, 2019

/lgtm

Copy link
Contributor

@bison bison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@eparis
Copy link
Member

eparis commented Aug 12, 2019

when do I get CI so this doesn't show up to start with?

@russellb
Copy link
Contributor Author

when do I get CI so this doesn't show up to start with?

once we can use openshift release images instead of building custom ones, and then we can build some proper CI integration with OpenShift.

getting an installer build into the release is the last thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants