Add volume type to represent shared volume for a Baremetal deployment

[sadasu]

Create a volume type to represent the shared volume used by various containers in a Baremetal deployment. Also, the Baremetal CRD needs it ordering number bumped up by 1.

[stbenjam]

Can you remove WIP from commit message + title if this is ready to go? Looks good to me.

[stbenjam]

/lgtm

[stbenjam]

/assign @frobware

[imain]

Looks good to me! Thanks Sandhya!

[enxebre]

Also, the Baremetal CRD needs it ordering number bumped up by 1.

can you elaborate why in the description?

[russellb]

Also, the Baremetal CRD needs it ordering number bumped up by 1.
can you elaborate why in the description?

I've pinged @sadasu on slack to ask, but AFAICT, it looks like it's just cosmetic, and not fixing anything

[enxebre]

@russellb @sadasu the local volume will be lost during rolling updates i.e during cluster upgrades, I assume you are good with that?

[russellb]

the local volume will be lost during rolling upgrades i.e during cluster upgrades, I assume you are good with that?

Yep - it's designed around losing all of this data anytime, just need to share some stuff between a handful of containers while they run

[russellb]

confirmed that the number change is just cosmetic btw @enxebre

[enxebre]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadasu]

Also, the Baremetal CRD needs it ordering number bumped up by 1.

can you elaborate why in the description?

@enxebre I had originally picked 12 in the filename (next seriel number that was available) and then a merge went just before mine that had grabbed that #. I missed this detail in my original commit and rebase won't flag that. I bumped the # in my filename to 13 to accommodate to accommodate the file naming convention.

[enxebre]

@sadasu cool see for more input on how ordering works https://github.com/openshift/cluster-version-operator/blob/master/docs/dev/operators.md#what-is-the-order-that-resources-get-createdupdated-in