Bug 1928948: openstack: Allow to skip master replica validation

[pierreprinetti]

With this patch, when the environment variable
OPENSHIFT_INSTALL_SKIP_PREFLIGHT_VALIDATIONS is set to "1", the
Installer skips the validation of the number of Control plane replicas.

[openshift-ci-robot]

@pierreprinetti: This pull request references Bugzilla bug 1928948, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1928948: openstack: Allow to skip master replica validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pierreprinetti after the PR has been reviewed.
You can assign the PR to them by writing /assign @pierreprinetti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/asset/installconfig/openstack/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[EmilienM]

/lgtm

[staebler]

The control plane replica check is not a pre-flight validation. It is a validation on the install config that has no dependence on the platform provider.

[pierreprinetti]

@staebler
I am confused by both statements. I'll try to be schematic:

1. the control plane replica check prevents installing; "pre-flight" is a loose term but I interpret it as "before installing", which AFAICS applies to this case
2. the validation is indeed platform-specific

Can you help me understand what is your suggested course of action?

[pierreprinetti]

/retest

[staebler]

My understanding of the purpose of the environment variable is that it is useful in CI where you either do not have access to a real OpenStack system or the OpenStack system does not support certain configurations that you want to test. Maybe I am missing how skipping this check helps with your CI tests.

From #4452,

Skipping pre-flight validations is essential to testing manifest
generation when the exotic settings under test are not available in the
CI infrastructure.

There are two types of validation-- static checks and pre-flight checks. A static check validates the install config in ways that do not require access to the platform provider (the OpenStack system in this case). A pre-flight check validates in ways that do require access to the platform provider. The validation of the number of control plane replicas is a static check, not a pre-flight check. If you are going to skip this validation, then you should also skip the static validation in the installconfig asset, which I do not believe is the behavior that we want.

[pierreprinetti]

The purpose of this change is to enable @akrzos to test single-node clusters.

I am not going to pretend I know what's the best way around the validation.

[openshift-ci]

@pierreprinetti: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-fips	7116a37	link	/test e2e-aws-fips

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[staebler]

The purpose of this change is to enable @akrzos to test single-node clusters.

I am not going to pretend I know what's the best way around the validation.

How can you perform a single-node installation when the terraform always creates 3 control-plane nodes?

[openshift-ci-robot]

@pierreprinetti: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[staebler]

@pierreprinetti Does #4672 obviate the need for these changes? Can we close this PR?

[openshift-ci-robot]

@pierreprinetti: This pull request references Bugzilla bug 1928948. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Bug 1928948: openstack: Allow to skip master replica validation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.