[release-4.2] Bug 1759245: Adds support for trailing dot in noProxy domain names

[openshift-cherrypick-robot]

This is an automated cherry-pick of #2405

/assign danehans

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1753930, which is invalid:

• expected the bug to target the "4.2.0" release, but it targets "4.3.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.2] Bug 1753930: Adds support for trailing dot in noProxy domain names

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[danehans]

/assign @wking

[danehans]

/retitle [release-4.2] Bug 1759245: Adds support for trailing dot in noProxy domain names

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1759245, which is invalid:

• expected the bug to target the "4.2.0" release, but it targets "4.2.z" instead
• expected dependent Bugzilla bug 1753930 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.2] Bug 1759245: Adds support for trailing dot in noProxy domain names

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

Clean cherry pick:

/lgtm

We won't be able to land this until the Bugzilla bot is happy (or a z patch manager overrides the bot), so currently waiting on bug 1753930 getting verified and 4.2.0 going out (to make this PR's 4.2.z target release appropriate). Or the severity on this bug motivating a change of Target Release to 4.2.0.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[wking]

/hold

Stop the retester.

[gpei]

@wking Any possible we can get this merged into 4.2.0, or else the installation on GCP with proxy enabled will be totally blocked when 4.2.0 released.

[sdodson]

/bugzilla reresh

[openshift-ci-robot]

@sdodson: This pull request references Bugzilla bug 1759245, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sdodson]

/test e2e-azure

[wking]

Any possible we can get this merged into 4.2.0...

That's up to the architects.

... or else the installation on GCP with proxy enabled will be totally blocked when 4.2.0 released.

Can you add a non-dot noProxy entry manually as a temporary workaround? But the bug currently targets 4.2.0, and that's how you ask for a release blocker. And tests look green, except for the still-pending Azure job.

[sdodson]

Can you add a non-dot noProxy entry manually as a temporary workaround? But the bug currently targets 4.2.0, and that's how you ask for a release blocker. And tests look green, except for the still-pending Azure job.

No, that doesn't work according to QE's testing where they added 'metadata.google.internal' to noProxy and it still failed. The kubelet uses a trailing dot.

https://bugzilla.redhat.com/show_bug.cgi?id=1753930#c0

[wking]

/hold cancel

[sdodson]

/test e2e-aws-upgrade

[wking]

e2e-aws:

level=error msg="Error: \"terraform-20191008151215150000000001\": NoSuchBucket: The specified bucket does not exist"
level=error msg="\tstatus code: 404, request id: 3129F43636FF9D74, host id: uDwLh1x/I8tjYFlYI1FS+FPfOdH2audQMJqF5POWZUdDz4ahojZYgAgHeP81A8BMGSYApzwJxZY="
level=error
level=error msg="  on ../tmp/openshift-install-387257564/bootstrap/main.tf line 1, in resource \"aws_s3_bucket\" \"ignition\":"
level=error msg="   1: resource \"aws_s3_bucket\" \"ignition\" {"

Dunno what that's about, but it's orthogonal to this PR.

/test e2e-aws

[wking]

Ah, maybe a race vs. the parallel e2e run (which also mostly runs on AWS). I'll wait a bit before kicking e2e off again.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[wking]

Nope, e2e run had different IDs:

$ curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/2464/pull-ci-openshift-installer-release-4.2-e2e/13/artifacts/e2e/installer/terraform.tfstate | grep terraform-201910
            "name": "terraform-20191008151220351500000004",
            "name": "terraform-20191008151219217200000003",
            "name": "terraform-20191008151219216500000002",

and failed with:

level=error msg="Error: Error creating S3 bucket: BucketAlreadyExists: The requested bucket name is not available. The bucket namespace is shared by all users of the system. Please select a different name and try again."
level=error msg="\tstatus code: 409, request id: 6E5F8A63395669BD, host id: rxHglrjAGOaSE/LJLOSOxbHH9kMNmDZJhlH04Fydif9zgUWK37D0si/HgG22HIbgkQY2vVQP22k="
level=error
level=error msg="  on ../tmp/openshift-install-215283988/bootstrap/main.tf line 1, in resource \"aws_s3_bucket\" \"ignition\":"
level=error msg="   1: resource \"aws_s3_bucket\" \"ignition\" {"

/test e2e

[openshift-ci-robot]

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e	49f9ea2	link	/test e2e
ci/prow/e2e-aws	49f9ea2	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sdodson]

/override ci/prow/e2e
/override ci/prow/e2e-aws-upgrade

[openshift-ci-robot]

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e, ci/prow/e2e-aws-upgrade

Details

In response to this:

/override ci/prow/e2e
/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

/override ci/prow/e2e-aws

That one too ;)

[openshift-ci-robot]

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aws

That one too ;)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.