NO-JIRA: fix(build): replace sysctl with getconf in Makefile #7282

cblecker · 2025-11-25T02:53:40Z

What this PR does / why we need it:

The sysctl command requires permissions not available in the macOS Seatbelt sandbox, causing 'Operation not permitted' errors. Replace it with getconf _NPROCESSORS_ONLN which is POSIX-compliant and works on both macOS and Linux without requiring special permissions.

openshift-ci · 2025-11-25T02:53:44Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2025-11-25T02:53:45Z

Walkthrough

Replaced Darwin-specific CPU-core detection in the Makefile with a portable getconf _NPROCESSORS_ONLN approach. Updated the test target to echo NUM_CORES and run go test with -race, -parallel=$(NUM_CORES), -count=1, -timeout=30m, and -coverprofile cover.out for ./....

Changes

Cohort / File(s)	Summary
Build and test configuration `Makefile`	Replaced CPU-core detection (Darwin-specific `uname`/`sysctl`/`nproc`) with portable `getconf _NPROCESSORS_ONLN`; updated `test` target to echo `NUM_CORES` and run `go test` with `-race`, `-parallel=$(NUM_CORES)`, `-count=1`, `-timeout=30m`, and `-coverprofile cover.out` for `./...`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Single-file build/test change; low complexity and repetitive pattern.
Check that getconf is available on CI runners where Makefile runs.
Verify go test flags and timeout align with project CI expectations.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 9a08c15 and 8f500fc.

📒 Files selected for processing (1)

Makefile (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

Makefile

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cblecker · 2025-11-25T02:54:21Z

/area ci-tooling

cblecker · 2025-11-25T02:57:13Z

/retry

The sysctl command requires permissions not available in the macOS Seatbelt sandbox, causing 'Operation not permitted' errors. Replace it with getconf _NPROCESSORS_ONLN which is POSIX-compliant and works on both macOS and Linux without requiring special permissions.

openshift-ci-robot · 2025-11-25T03:13:14Z

@cblecker: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:

The sysctl command requires permissions not available in the macOS Seatbelt sandbox, causing 'Operation not permitted' errors. Replace it with getconf _NPROCESSORS_ONLN which is POSIX-compliant and works on both macOS and Linux without requiring special permissions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-25T03:16:09Z

@cblecker: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

In response to this:

/verified manually

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-25T03:16:54Z

@cblecker: This PR has been marked as verified by @cblecker manually.

In response to this:

/verified by @cblecker manually

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cblecker · 2025-11-25T03:17:28Z

/verified bypass

openshift-ci-robot · 2025-11-25T03:17:37Z

@cblecker:

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cblecker · 2025-11-25T05:21:37Z

/retest

cblecker · 2025-11-25T06:44:18Z

/retest

cblecker · 2025-11-25T14:58:53Z

/retest

cblecker · 2025-11-25T17:17:43Z

/retest

openshift-ci · 2025-11-26T04:03:23Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cblecker · 2025-11-26T06:09:09Z

/retest-required

bryan-cox · 2025-11-26T13:43:27Z

/test e2e-aks

bryan-cox · 2025-11-26T15:43:50Z

/lgtm

openshift-ci-robot · 2025-11-28T07:38:51Z

/retest-required

Remaining retests: 0 against base HEAD 50304c0 and 2 for PR HEAD 8f500fc in total

cblecker · 2025-11-28T09:01:17Z

/retest

openshift-ci-robot · 2025-11-28T15:38:57Z

/retest-required

Remaining retests: 0 against base HEAD 3f2c3ad and 1 for PR HEAD 8f500fc in total

cblecker · 2025-11-28T16:59:13Z

/retest

cblecker · 2025-11-28T18:58:41Z

/retest

cblecker · 2025-11-28T21:29:24Z

/retest

openshift-ci-robot · 2025-11-28T23:38:46Z

/retest-required

Remaining retests: 0 against base HEAD 0c8ff10 and 0 for PR HEAD 8f500fc in total

openshift-ci-robot · 2025-11-29T00:38:41Z

/hold

Revision 8f500fc was retested 3 times: holding

bryan-cox · 2025-11-29T01:29:19Z

/test e2e-aks

cblecker · 2025-11-29T02:02:31Z

/retest

cblecker · 2025-11-29T04:52:48Z

/retest

cblecker · 2025-11-29T06:41:35Z

/hold cancel

openshift-ci · 2025-11-29T08:36:16Z

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2025

cblecker marked this pull request as ready for review November 25, 2025 02:53

openshift-ci bot added do-not-merge/needs-area and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 25, 2025

openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Nov 25, 2025

openshift-ci bot requested review from bryan-cox and jparrill November 25, 2025 02:54

cblecker force-pushed the fix/replace-sysctl-with-getconf-in-makefile branch from 9a08c15 to 8f500fc Compare November 25, 2025 02:58

cblecker changed the title ~~fix(build): replace sysctl with getconf in Makefile~~ NO-JIRA: fix(build): replace sysctl with getconf in Makefile Nov 25, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 25, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 25, 2025

csrwng added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025

openshift-ci bot assigned bryan-cox Nov 26, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2025

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2025

openshift-merge-bot bot merged commit 760fec5 into openshift:main Nov 29, 2025
19 checks passed

cblecker deleted the fix/replace-sysctl-with-getconf-in-makefile branch November 29, 2025 08:40

NO-JIRA: fix(build): replace sysctl with getconf in Makefile #7282

NO-JIRA: fix(build): replace sysctl with getconf in Makefile #7282

Conversation

cblecker commented Nov 25, 2025

What this PR does / why we need it:

Uh oh!

openshift-ci bot commented Nov 25, 2025

Uh oh!

coderabbitai bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

cblecker commented Nov 25, 2025

Uh oh!

cblecker commented Nov 25, 2025

Uh oh!

openshift-ci-robot commented Nov 25, 2025

What this PR does / why we need it:

Uh oh!

openshift-ci-robot commented Nov 25, 2025

Uh oh!

openshift-ci-robot commented Nov 25, 2025

Uh oh!

cblecker commented Nov 25, 2025

Uh oh!

openshift-ci-robot commented Nov 25, 2025

Uh oh!

cblecker commented Nov 25, 2025

Uh oh!

cblecker commented Nov 25, 2025

Uh oh!

cblecker commented Nov 25, 2025

Uh oh!

cblecker commented Nov 25, 2025

Uh oh!

openshift-ci bot commented Nov 26, 2025

Uh oh!

cblecker commented Nov 26, 2025

Uh oh!

bryan-cox commented Nov 26, 2025

Uh oh!

bryan-cox commented Nov 26, 2025

Uh oh!

openshift-ci-robot commented Nov 28, 2025

Uh oh!

cblecker commented Nov 28, 2025

Uh oh!

openshift-ci-robot commented Nov 28, 2025

Uh oh!

cblecker commented Nov 28, 2025

Uh oh!

cblecker commented Nov 28, 2025

Uh oh!

cblecker commented Nov 28, 2025

Uh oh!

openshift-ci-robot commented Nov 28, 2025

Uh oh!

openshift-ci-robot commented Nov 29, 2025

Uh oh!

bryan-cox commented Nov 29, 2025

Uh oh!

cblecker commented Nov 29, 2025

Uh oh!

cblecker commented Nov 29, 2025

Uh oh!

cblecker commented Nov 29, 2025

Uh oh!

openshift-ci bot commented Nov 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Nov 25, 2025 •

edited

Loading