Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented Jun 13, 2018

@sjenning
Copy link

merged upstream and lgtm

@sjenning sjenning merged commit 506fcde into openshift:openshift-3.10-cadvisor-v0.29.1 Jun 13, 2018
@runcom runcom deleted the fix-bz-1590563 branch June 13, 2018 17:46
@liggitt
Copy link

liggitt commented Jun 13, 2018

this got pulled into dep update in openshift/origin#19992 and doesn't appear to compile... is there a coordinating PR required?

# github.com/openshift/origin/vendor/github.com/google/cadvisor/container/docker
vendor/github.com/google/cadvisor/container/docker/handler.go:250:9: handler.restartCount undefined (type *dockerContainerHandler has no field or method restartCount)
[ERROR] [18:10:08+0000] PID 78: hack/lib/build/binaries.sh:236: `GOOS=${platform%/*} GOARCH=${platform##*/} go install -pkgdir "${pkgdir}/${platform}" -tags "${OS_GOFLAGS_TAGS-} ${!platform_gotags_envvar:-}" -ldflags="${local_ldflags}" "${goflags[@]:+${goflags[@]}}" -gcflags "${gogcflags}" "${nonstatics[@]}"` exited with status 2.

@deads2k
Copy link

deads2k commented Jun 13, 2018

this got pulled into dep update in openshift/origin#19992 and doesn't appear to compile... is there a coordinating PR required?

update glide.yaml to point to a SHA and they'll deal with it.

handler.image = ctnr.Config.Image
handler.networkMode = ctnr.HostConfig.NetworkMode
handler.deviceID = ctnr.GraphDriver.Data["DeviceId"]
handler.restartCount = ctnr.RestartCount

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line needed to be removed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is correct upstream :-/ not sure how it didn't make the pick.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure either indeed, my bad guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants