ODC-6786: Add cluster configuration extension, page, and options for console customization #12159

christoph-jerolimov · 2022-10-12T01:13:55Z

Fixes:

https://issues.redhat.com/browse/ODC-6786 Allow the user to hide perspectives using a form-driven experience
https://issues.redhat.com/browse/ODC-6781 Allow the user to hide sub-catalogs in the developer catalog or the entire dev catalog using a form-driven experience
Implements a form-driven experience also for Quick Starts, Developer Add Page actions, and ****.

Solution Description:
Implement cluster configuration extension and page that looks similar to user preferences.

Screenshots / Gifs for design review:

New action menu on "Console" (operator.openshift.io) resource:

General configurations:

Perspective options:

"Saved." alert when changing an option:

Filters are implemented with fuzzy search:

Projects configurations:

Developer configurations:

Unit test coverage report:

Test setup:

Switch to the "Administrator" perspective
Navigate to "Administration" > "Cluster Settings" and open the "Configuration" tab
Navigate to "Console" (operator.openshift.io) in two tabs:
1. Keep the YAML open and
2. Open the (new) actions menu and select "Customize" in a second tab
Change some options to customize the console
1. The form auto-saves changes after 2 seconds and shows a green alert "Saved."
2. The YAML should be updated immediately
3. The console requires a new roll out, this can take some seconds (up to a minute) and requires you to reload the browser.

Browser conformance:

Chrome
Firefox
Safari
Edge

christoph-jerolimov · 2022-10-12T01:15:05Z

/uncc cyril-ui-developer dtaylor113
/cc @debsmita1 @lokanandaprabhu @invincibleJai

christoph-jerolimov · 2022-10-12T23:58:14Z

/cc @serenamarie125 @beaumorley

invincibleJai · 2022-10-13T12:04:09Z

Thanks @jerolimov, this looks good 🎉

Had some observations which have listed below:

Getting i18n error on console

I disabled all QuickStarts and then whent to QuickStarts page and it showed as below, may be we can take as follow up to show proper empty screen as this is not related to this PR

Getting 422 on moving catlog item from disabled to enabled for Helm Charts

forntend job needs ❤️

invincibleJai · 2022-10-13T12:37:12Z

frontend/packages/console-app/console-extensions.json

nit: shall we remove the commented extensions and some of the commented lines below?

invincibleJai · 2022-10-13T13:24:27Z

...kages/console-app/src/components/cluster-configuration/ClusterConfigurationCheckboxField.tsx

do we need this?

invincibleJai · 2022-10-13T13:25:06Z

...kages/console-app/src/components/cluster-configuration/ClusterConfigurationCheckboxField.tsx

title value is asd?

invincibleJai · 2022-10-13T13:34:52Z

...kages/console-app/src/components/cluster-configuration/ClusterConfigurationDropdownField.tsx

shall we add check on options?

...tend/packages/console-app/src/components/cluster-configuration/ClusterConfigurationPage.scss

frontend/packages/console-app/src/components/cluster-configuration/ClusterConfigurationPage.tsx

frontend/packages/console-shared/src/components/cluster-configuration/SaveStatus.tsx

frontend/packages/dev-console/src/components/project-access/ProjectAccessRolesConfiguration.tsx

debsmita1 · 2022-10-17T11:01:05Z

No heading for developer catalog types

christoph-jerolimov · 2022-10-17T15:37:35Z

@debsmita1

No heading for developer catalog types

Fixed

sanketpathak · 2022-10-18T09:46:43Z

@jerolimov saw this issue while sending quick starts from enabled to disabled regions
When one item got moved I tried to move the complete list but it didn't happen
Screencast from 10-18-2022 03:04:26 PM.webm

christoph-jerolimov · 2022-10-19T05:44:37Z

@jerolimov saw this issue while sending quick starts from enabled to disabled regions

When one item got moved I tried to move the complete list but it didn't happen

Screencast.from.10-18-2022.03.04.26.PM.webm

After some investigation I found that this is an issue in the PF DualListSelector component.

I opened a PF bug report with an exact description how to reproduce this and a bug fix as well:
patternfly/patternfly-react#8268
patternfly/patternfly-react#8269

sanketpathak · 2022-10-19T18:40:43Z

Verified on a cluster with cluster-bot
Screencast from 10-19-2022 10:58:59 PM.webm
/label qe-approved

debsmita1 · 2022-10-20T10:43:30Z

/lgtm

openshift-ci · 2022-10-20T10:43:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-10-20T11:24:01Z

@jerolimov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot requested review from cajieh and dtaylor113 October 12, 2022 01:14

christoph-jerolimov changed the title ~~ODC-6786: Add cluster configuration extension, page, and options for console customization~~ [WIP] ODC-6786: Add cluster configuration extension, page, and options for console customization Oct 12, 2022

openshift-ci bot requested review from debsmita1, invincibleJai and lokanandaprabhu and removed request for cajieh and dtaylor113 October 12, 2022 01:15

christoph-jerolimov force-pushed the cluster-configuration branch 2 times, most recently from 6b519f1 to ea992cc Compare October 12, 2022 23:39

christoph-jerolimov changed the title ~~[WIP] ODC-6786: Add cluster configuration extension, page, and options for console customization~~ ODC-6786: Add cluster configuration extension, page, and options for console customization Oct 12, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2022

openshift-ci bot requested review from beaumorley and serenamarie125 October 12, 2022 23:58

christoph-jerolimov force-pushed the cluster-configuration branch from ea992cc to 69172ea Compare October 13, 2022 00:07

invincibleJai reviewed Oct 13, 2022

View reviewed changes

frontend/packages/console-shared/src/components/cluster-configuration/SaveStatus.tsx Outdated Show resolved Hide resolved

debsmita1 suggested changes Oct 14, 2022

View reviewed changes

frontend/packages/dev-console/src/components/project-access/ProjectAccessRolesConfiguration.tsx Outdated Show resolved Hide resolved

christoph-jerolimov mentioned this pull request Oct 14, 2022

OCPBUGS-2430: Add missing Quick Start translation #12171

Merged

4 tasks

christoph-jerolimov force-pushed the cluster-configuration branch from 69172ea to 8961ed9 Compare October 15, 2022 22:29

christoph-jerolimov force-pushed the cluster-configuration branch from f723f31 to 6450aad Compare October 17, 2022 11:53

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2022

christoph-jerolimov force-pushed the cluster-configuration branch from 698ffee to 768b9cb Compare October 17, 2022 20:51

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2022

christoph-jerolimov force-pushed the cluster-configuration branch 3 times, most recently from 9d9fb8c to 44f25d9 Compare October 18, 2022 09:01

christoph-jerolimov mentioned this pull request Oct 18, 2022

fix(DualListSelector): Add/remove button didn't work if search is used patternfly/patternfly-react#8269

Merged

christoph-jerolimov force-pushed the cluster-configuration branch from 44f25d9 to 82ca5e9 Compare October 18, 2022 23:24

christoph-jerolimov mentioned this pull request Oct 18, 2022

Bug - DualListSelector - Add/remove button doesn't work fine if search is used patternfly/patternfly-react#8268

Closed

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 19, 2022

christoph-jerolimov force-pushed the cluster-configuration branch 2 times, most recently from 2178fc4 to 7f72825 Compare October 20, 2022 07:30

christoph-jerolimov and others added 4 commits October 20, 2022 09:47

Add cluster configuration extension and configuration page

c32440e

Add customize option to console detail page (#7)

afce33c

Implement cluster configuration options

e524425

add telemetry event for cluster configuration changes (#8)

8812f02

christoph-jerolimov force-pushed the cluster-configuration branch from 7f72825 to 8812f02 Compare October 20, 2022 07:53

openshift-ci bot assigned debsmita1 Oct 20, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022

openshift-merge-robot merged commit ee068c1 into openshift:master Oct 20, 2022

christoph-jerolimov deleted the cluster-configuration branch August 7, 2023 13:16

ODC-6786: Add cluster configuration extension, page, and options for console customization #12159

ODC-6786: Add cluster configuration extension, page, and options for console customization #12159

Uh oh!

Conversation

christoph-jerolimov commented Oct 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New action menu on "Console" (operator.openshift.io) resource:

General configurations:

Perspective options:

"Saved." alert when changing an option:

Filters are implemented with fuzzy search:

Projects configurations:

Developer configurations:

Uh oh!

christoph-jerolimov commented Oct 12, 2022

Uh oh!

christoph-jerolimov commented Oct 12, 2022

Uh oh!

invincibleJai commented Oct 13, 2022

Uh oh!

invincibleJai Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

invincibleJai Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

invincibleJai Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

invincibleJai Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

debsmita1 commented Oct 17, 2022

Uh oh!

christoph-jerolimov commented Oct 17, 2022

Uh oh!

sanketpathak commented Oct 18, 2022

Uh oh!

christoph-jerolimov commented Oct 19, 2022

Uh oh!

sanketpathak commented Oct 19, 2022

Uh oh!

debsmita1 commented Oct 20, 2022

Uh oh!

openshift-ci bot commented Oct 20, 2022

Uh oh!

openshift-ci bot commented Oct 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

christoph-jerolimov commented Oct 12, 2022 •

edited

Loading